ACPI suspend: Execute _WAK with the right argument
PATCH 1/1 ACPI suspend: Execute _WAK with the right argument
From: Rafael J. Wysocki <[email protected]>
The _WAK global ACPI control method has to be called with the argument representing the sleep state being exited. Make it happen.
Special thanks to Mirco Tischler <[email protected]> for reporting the problem and debugging.
--- drivers/acpi/hardware/hwsleep.c | 1 + 1 file changed, 1 insertion(+)
drivers/acpi/hardware/hwsleep.c +1 -0
@@ -616,6 +616,7 @@ acpi_status acpi_leave_sleep_state(u8 slreturn_ACPI_STATUS (status); } + arg.integer.value = sleep_state; status =acpi_evaluate_object (NULL ,METHOD_NAME__WAK , &arg_list,NULL );if (ACPI_FAILURE (status) && status !=AE_NOT_FOUND ) {ACPI_EXCEPTION ((AE_INFO , status,"During Method _WAK" ));
Quoted 10 lines · Rafael J. Wysocki
From: Rafael J. Wysocki <[email protected]>
The
_WAKglobal ACPI control method has to be called with the argument representing the sleep state being exited. Make it happen.Special thanks to Mirco Tischler <[email protected]> for reporting the problem and debugging.
Reported-by Mirco Tischler <[email protected]>Signed-off-by Rafael J. Wysocki <[email protected]>
ACK. AFAICT this is 2.6.25 material.
Pavel
Quoted 16 lines
--- drivers/acpi/hardware/hwsleep.c | 1 + 1 file changed, 1 insertion(+)Index:
linux-2.6/drivers/acpi/hardware/hwsleep.c
===================================================================drivers/acpi/hardware/hwsleep.c +1
-0@@ -616,6 +616,7 @@ acpi_status acpi_leave_sleep_state(u8 slreturn_ACPI_STATUS (status); } + arg.integer.value = sleep_state; status =acpi_evaluate_object (NULL ,METHOD_NAME__WAK , &arg_list,NULL );if (ACPI_FAILURE (status) && status !=AE_NOT_FOUND ) {ACPI_EXCEPTION ((AE_INFO , status,"During Method _WAK" ));
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Quoted 6 lines · Pavel Machek
Quoted 5 lines · Rafael J. Wysocki
From: Rafael J. Wysocki <[email protected]>
The
_WAKglobal ACPI control method has to be called with the argument representing the sleep state being exited. Make it happen.
Quoted 7 lines
Quoted 5 lines
Special thanks to Mirco Tischler <[email protected]> for reporting the problem and debugging.
Reported-by Mirco Tischler <[email protected]>Signed-off-by Rafael J. Wysocki <[email protected]>ACK. AFAICT this is 2.6.25 material.
Sure, it certainly is. The bug has been breaking suspend on people's boxes already.
Thanks,
Rafael
Quoted 17 lines
Quoted 16 lines
--- drivers/acpi/hardware/hwsleep.c | 1 + 1 file changed, 1 insertion(+)Index:
linux-2.6/drivers/acpi/hardware/hwsleep.c
===================================================================drivers/acpi/hardware/hwsleep.c +1
-0@@ -616,6 +616,7 @@ acpi_status acpi_leave_sleep_state(u8 slreturn_ACPI_STATUS (status); } + arg.integer.value = sleep_state; status =acpi_evaluate_object (NULL ,METHOD_NAME__WAK , &arg_list,NULL );if (ACPI_FAILURE (status) && status !=AE_NOT_FOUND ) {ACPI_EXCEPTION ((AE_INFO , status,"During Method _WAK" ));
Quoted 6 lines · Pavel Machek
Quoted 5 lines · Rafael J. Wysocki
From: Rafael J. Wysocki <[email protected]>
The
_WAKglobal ACPI control method has to be called with the argument representing the sleep state being exited. Make it happen.
Quoted 7 lines
Quoted 5 lines
Special thanks to Mirco Tischler <[email protected]> for reporting the problem and debugging.
Reported-by Mirco Tischler <[email protected]>Signed-off-by Rafael J. Wysocki <[email protected]>ACK. AFAICT this is 2.6.25 material.
Sure, it certainly is. The bug has been breaking suspend on people's boxes already.
Thanks,
Rafael
Quoted 17 lines
Quoted 16 lines
--- drivers/acpi/hardware/hwsleep.c | 1 + 1 file changed, 1 insertion(+)Index:
linux-2.6/drivers/acpi/hardware/hwsleep.c
===================================================================drivers/acpi/hardware/hwsleep.c +1
-0@@ -616,6 +616,7 @@ acpi_status acpi_leave_sleep_state(u8 slreturn_ACPI_STATUS (status); } + arg.integer.value = sleep_state; status =acpi_evaluate_object (NULL ,METHOD_NAME__WAK , &arg_list,NULL );if (ACPI_FAILURE (status) && status !=AE_NOT_FOUND ) {ACPI_EXCEPTION ((AE_INFO , status,"During Method _WAK" ));
Quoted 10 lines · Rafael J. Wysocki
From: Rafael J. Wysocki <[email protected]>
The
_WAKglobal ACPI control method has to be called with the argument representing the sleep state being exited. Make it happen.Special thanks to Mirco Tischler <[email protected]> for reporting the problem and debugging.
Reported-by Mirco Tischler <[email protected]>Signed-off-by Rafael J. Wysocki <[email protected]>
ACK. AFAICT this is 2.6.25 material.
Pavel
Quoted 16 lines
--- drivers/acpi/hardware/hwsleep.c | 1 + 1 file changed, 1 insertion(+)Index:
linux-2.6/drivers/acpi/hardware/hwsleep.c
===================================================================drivers/acpi/hardware/hwsleep.c +1
-0@@ -616,6 +616,7 @@ acpi_status acpi_leave_sleep_state(u8 slreturn_ACPI_STATUS (status); } + arg.integer.value = sleep_state; status =acpi_evaluate_object (NULL ,METHOD_NAME__WAK , &arg_list,NULL );if (ACPI_FAILURE (status) && status !=AE_NOT_FOUND ) {ACPI_EXCEPTION ((AE_INFO , status,"During Method _WAK" ));
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
applied
thanks for quickly finding and fixing this 2.6.25-rc1 regression.
-len
Quoted 32 lines · Rafael J. Wysocki
From: Rafael J. Wysocki <[email protected]>
The
_WAKglobal ACPI control method has to be called with the argument representing the sleep state being exited. Make it happen.Special thanks to Mirco Tischler <[email protected]> for reporting the problem and debugging.
Reported-by Mirco Tischler <[email protected]>Signed-off-by Rafael J. Wysocki <[email protected]>--- drivers/acpi/hardware/hwsleep.c | 1 + 1 file changed, 1 insertion(+)Index:
linux-2.6/drivers/acpi/hardware/hwsleep.c
===================================================================drivers/acpi/hardware/hwsleep.c +1
-1@@ -616,6 +616,7 @@ acpi_status acpi_leave_sleep_state(u8 slreturn_ACPI_STATUS (status); } + arg.integer.value = sleep_state; status =acpi_evaluate_object (NULL ,METHOD_NAME__WAK , &arg_list,NULL );if (ACPI_FAILURE (status) && status !=AE_NOT_FOUND ) {ACPI_EXCEPTION ((AE_INFO , status,"During Method _WAK" )); --To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
applied
thanks for quickly finding and fixing this 2.6.25-rc1 regression.
-len
Quoted 32 lines · Rafael J. Wysocki
From: Rafael J. Wysocki <[email protected]>
The
_WAKglobal ACPI control method has to be called with the argument representing the sleep state being exited. Make it happen.Special thanks to Mirco Tischler <[email protected]> for reporting the problem and debugging.
Reported-by Mirco Tischler <[email protected]>Signed-off-by Rafael J. Wysocki <[email protected]>--- drivers/acpi/hardware/hwsleep.c | 1 + 1 file changed, 1 insertion(+)Index:
linux-2.6/drivers/acpi/hardware/hwsleep.c
===================================================================drivers/acpi/hardware/hwsleep.c +1
-1@@ -616,6 +616,7 @@ acpi_status acpi_leave_sleep_state(u8 slreturn_ACPI_STATUS (status); } + arg.integer.value = sleep_state; status =acpi_evaluate_object (NULL ,METHOD_NAME__WAK , &arg_list,NULL );if (ACPI_FAILURE (status) && status !=AE_NOT_FOUND ) {ACPI_EXCEPTION ((AE_INFO , status,"During Method _WAK" )); --To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/