Skip to contentSkip to conversation

Update various classifiers' help output for expected CLASSID syntax

PATCH In review PJ Waskiewicz 2 participants 3 messages Feb 13, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Update various classifiers' help output for expected CLASSID syntax

This updates the help output to specify that CLASSID should be hexidecimal. This makes sure that a user entering "flowid 1:10" gets his flow put into band 15 (0x10) and knows why.

---

 doc/actions/actions-general |    3 +++
 tc/f_basic.c                |    1 +
 tc/f_fw.c                   |    1 +
 tc/f_route.c                |    1 +
 tc/f_rsvp.c                 |    1 +
 tc/f_u32.c                  |    1 +
 6 files changed, 8 insertions(+), 0 deletions(-)
doc/actions/actions-general +3 -0
index 6561eda..70f7cd6 100644
@@ -88,6 +88,9 @@ tc filter add dev lo parent ffff: protocol ip prio 8 u32 \
 match ip dst 127.0.0.8/32 flowid 1:12 \
 action ipt -j mark --set-mark 2
 
+NOTE: flowid 1:12 is parsed flowid 0x1:0x12.  Make sure if you want flowid
+decimal 12, then use flowid 1:c.
+
 3) A feature i call pipe
 The motivation is derived from Unix pipe mechanism but applied to packets.
 Essentially take a matching packet and pass it through 
tc/f_basic.c +1 -0
index 19a7edf..d6d7767 100644
@@ -32,6 +32,7 @@ static void explain(void)
 	fprintf(stderr, "\n");
 	fprintf(stderr, "Where: SELECTOR := SAMPLE SAMPLE ...\n");
 	fprintf(stderr, "       FILTERID := X:Y:Z\n");
+	fprintf(stderr, "\nNOTE: CLASSID is parsed as hexidecimal input.\n");
 }
 
 static int basic_parse_opt(struct filter_util *qu, char *handle,
tc/f_fw.c +1 -0
index 6d1490b..9f4ef6e 100644
@@ -28,6 +28,7 @@ static void explain(void)
 	fprintf(stderr, "Usage: ... fw [ classid CLASSID ] [ police POLICE_SPEC ]\n");
 	fprintf(stderr, "       POLICE_SPEC := ... look at TBF\n");
 	fprintf(stderr, "       CLASSID := X:Y\n");
+	fprintf(stderr, "\nNOTE: CLASSID is parsed as hexidecimal input.\n");
 }
 
 #define usage() return(-1)
tc/f_route.c +1 -0
index a41b9d5..3bb963c 100644
@@ -31,6 +31,7 @@ static void explain(void)
 	fprintf(stderr, "                [ flowid CLASSID ] [ police POLICE_SPEC ]\n");
 	fprintf(stderr, "       POLICE_SPEC := ... look at TBF\n");
 	fprintf(stderr, "       CLASSID := X:Y\n");
+	fprintf(stderr, "\nNOTE: CLASSID is parsed as hexidecimal input.\n");
 }
 
 #define usage() return(-1)
tc/f_rsvp.c +1 -0
index 13fcf97..9019ee2 100644
@@ -34,6 +34,7 @@ static void explain(void)
 	fprintf(stderr, "                u{8|16|32} NUMBER mask MASK at OFFSET}\n");
 	fprintf(stderr, "       POLICE_SPEC := ... look at TBF\n");
 	fprintf(stderr, "       FILTERID := X:Y\n");
+	fprintf(stderr, "\nNOTE: CLASSID is parsed as hexidecimal input.\n");
 }
 
 #define usage() return(-1)
tc/f_u32.c +1 -0
index 91f2838..d38c536 100644
@@ -36,6 +36,7 @@ static void explain(void)
 	fprintf(stderr, "Where: SELECTOR := SAMPLE SAMPLE ...\n");
 	fprintf(stderr, "       SAMPLE := { ip | ip6 | udp | tcp | icmp | u{32|16|8} | mark } SAMPLE_ARGS [divisor DIVISOR]\n");
 	fprintf(stderr, "       FILTERID := X:Y:Z\n");
+	fprintf(stderr, "\nNOTE: CLASSID is parsed at hexidecimal input.\n");
 }
 
 #define usage() return(-1)
#1 lore raw
Quoted 1 line · PJ Waskiewicz

This updates the help output to specify that CLASSID should be hexidecimal.

...

Review

Quoted 1 line
(quoted diff) +1 -0
+	fprintf(stderr, "\nNOTE: CLASSID is parsed as hexidecimal input.\n");

s/hexidecimal/hexadecimal/g (?)

Regards,
Jarek P.

#2 lore raw

RE: [PATCH] [IPROUTE2] Update various classifiers' help output forexpected CLASSID syntax

Quoted 4 lines

Review

Quoted 2 lines
(quoted diff) +2 -0
+	fprintf(stderr, "\nNOTE: CLASSID is parsed as hexidecimal 
+input.\n");

s/hexidecimal/hexadecimal/g (?)

Gah! Thanks Jarek, I can correct and resend.

-PJ Waskiewicz