Skip to contentSkip to conversation

x86: pit_clockevent can be static

PATCH Applied Harvey Harrison 3 participants 3 messages Feb 12, 2008 – Feb 16, 2008 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: pit_clockevent can be static

arch/x86/kernel/i8253.c:98:27: warning: symbol 'pit_clockevent' was not declared. Should it be static?

---
 arch/x86/kernel/i8253.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/i8253.c +1 -1
index ef62b07..8540abe 100644
@@ -95,7 +95,7 @@ static int pit_next_event(unsigned long delta, struct clock_event_device *evt)
  * registered. This mechanism replaces the previous #ifdef LOCAL_APIC -
  * !using_apic_timer decisions in do_timer_interrupt_hook()
  */
-struct clock_event_device pit_clockevent = {
+static struct clock_event_device pit_clockevent = {
 	.name		= "pit",
 	.features	= CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT,
 	.set_mode	= init_pit_timer,
Signature · 1 line
1.5.4.1.1278.gc75be
#1 lore raw
Quoted 2 lines · Harvey Harrison

arch/x86/kernel/i8253.c:98:27: warning: symbol 'pit_clockevent' was not declared. Should it be static?

yeah. Thanks Harvey, applied.

Ingo