ARM926: compile cpu_init_crit function only if CONFIG_SKIP_LOWLEVEL_INIT is not defined

PATCH New Hebbar 3 participants 7 messages Dec 18, 2007 – Feb 14, 2008

lore

Share & tools

lore

Hebbar

author

2007-12-18 23:52 UTC #0 lore raw

PATCH 1/1 ARM926: compile cpu_init_crit function only if CONFIG_SKIP_LOWLEVEL_INIT is not defined

Hi,

This patches allows cpu_init_crit function to be compilled only if CONFIG_SKIP_LOWLEVEL_INIT is not defined. At present irrespective of CONFIG_SKIP_LOWLEVEL_INIT, cpu_init_crit is always compilled. This is for arm926ejs module.

cpu/arm926ejs/start.S +4 -1

@@ -187,7 +187,7 @@ clbss_l:str	r2, [r0]		/* clear loop...  
 _start_armboot:
 	.word start_armboot
 
-
+#ifndef CONFIG_SKIP_LOWLEVEL_INIT
 /*
  *************************************************************************
  *

@@ -225,6 +225,9 @@ cpu_init_crit:
 	bl	lowlevel_init	/* go setup pll,mux,memory */
 	mov	lr, ip		/* restore link */
 	mov	pc, lr		/* back to my caller */
+	
+#endif /* CONFIG_SKIP_LOWLEVEL_INIT */
+	
 /*
  *************************************************************************
  *

Signed-off-by Hebbar

I welcome comments, complaints, suggestions and advices.

Regards
Gururaja

Signature · 2 lines

View this message in context: http://www.nabble.com/-PATCH--ARM926%3A-compile-cpu_init_crit-function-only-if-CONFIG_SKIP_LOWLEVEL_INIT-is-not-defined-tp14408413p14408413.html
Sent from the Uboot - Users mailing list archive at Nabble.com.

Hebbar

author

2007-12-18 23:59 UTC #1 lore raw

PATCH 1/1 ARM926: compile cpu_init_crit function only if CONFIG_SKIP_LOWLEVEL_INIT is not defined

Hi,

Signed-off-by K R Gururaja Hebbar <[email protected]>

cpu/arm926ejs/start.S +4 -1

@@ -187,7 +187,7 @@ clbss_l:str	r2, [r0]		/* clear loop...  
 _start_armboot:
 	.word start_armboot
 
-
+#ifndef CONFIG_SKIP_LOWLEVEL_INIT
 /*
  *************************************************************************
  *

@@ -225,6 +225,9 @@ cpu_init_crit:
 	bl	lowlevel_init	/* go setup pll,mux,memory */
 	mov	lr, ip		/* restore link */
 	mov	pc, lr		/* back to my caller */
+	
+#endif /* CONFIG_SKIP_LOWLEVEL_INIT */
+	
 /*
  *************************************************************************
  *

I welcome comments, complaints, suggestions and advices.

Regards
Gururaja

Signature · 2 lines

View this message in context: http://www.nabble.com/-PATCH--ARM926%3A-compile-cpu_init_crit-function-only-if-CONFIG_SKIP_LOWLEVEL_INIT-is-not-defined-tp14408413p14408491.html
Sent from the Uboot - Users mailing list archive at Nabble.com.

Dirk Behme

2007-12-19 06:27 UTC #2 lore raw

PATCH 1/1 ARM926: compile cpu_init_crit function only if CONFIG_SKIP_LOWLEVEL_INIT is not defined

Quoted 29 lines · Hebbar

This patches allows cpu_init_crit function to be compilled only if CONFIG_SKIP_LOWLEVEL_INIT is not defined. At present irrespective of CONFIG_SKIP_LOWLEVEL_INIT, cpu_init_crit is always compilled. This is for arm926ejs module.
Signed-off-by K R Gururaja Hebbar <[email protected]>
cpu/arm926ejs/start.S +4 -1
@@ -187,7 +187,7 @@ clbss_l:str	r2, [r0]		/* clear loop...  
 _start_armboot:
 	.word start_armboot
 
-
+#ifndef CONFIG_SKIP_LOWLEVEL_INIT
 /*
  *************************************************************************
  *
@@ -225,6 +225,9 @@ cpu_init_crit:
 	bl	lowlevel_init	/* go setup pll,mux,memory */
 	mov	lr, ip		/* restore link */
 	mov	pc, lr		/* back to my caller */
+	
+#endif /* CONFIG_SKIP_LOWLEVEL_INIT */
+	
 /*
  *************************************************************************
  *

Quoted 1 line

I welcome comments, complaints, suggestions and advices.

The reason for this is to decrease resulting binary size? If so, all lowlevel_init() should be encapsulated as well to save even more space?

Dirk

Wolfgang Denk

2008-02-04 22:38 UTC #3 lore raw

PATCH 1/1 ARM926: compile cpu_init_crit function only if CONFIG_SKIP_LOWLEVEL_INIT is not defined

In reply to Hebbar

Quoted 5 lines · In message <[email protected]> you wrote:

This patches allows cpu_init_crit function to be compilled only if CONFIG_SKIP_LOWLEVEL_INIT is not defined. At present irrespective of CONFIG_SKIP_LOWLEVEL_INIT, cpu_init_crit is always compilled. This is for arm926ejs module.

I'm not sure about this one. Probably the whole cpu_init_crit: part should be placed inside the "#ifndef CONFIG_SKIP_LOWLEVEL_INIT" part, as it is done for example in "cpu/arm920t/start.S" ?

Not applied.

Best regards,

Wolfgang Denk

Signature · 5 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A direct quote from the Boss: "We passed over a lot of good people to
get the ones we hired."

Hebbar

author

2008-02-05 01:32 UTC #4 lore raw

PATCH 1/1 ARM926: compile cpu_init_crit function only if CONFIG_SKIP_LOWLEVEL_INIT is not defined

Hi Wolfgang ,

At Present the call to "cpu_init_crit" in uboot/cpu/arm926ejs/start.S (142) is under ifndef

#ifndef CONFIG_SKIP_LOWLEVEL_INIT
bl cpu_init_crit
#endif

But the function definition (203) isn't under this ifndef. So irrespective
of CONFIG_SKIP_LOWLEVEL_INIT, this function is compiled. Hence i have applied the ifndef to function definition which places the entire cpu_init_crit inside the ifndef.

Regards
Gururaja

Quoted 5 lines · In message <[email protected]> you wrote:

This patches allows cpu_init_crit function to be compilled only if CONFIG_SKIP_LOWLEVEL_INIT is not defined. At present irrespective of CONFIG_SKIP_LOWLEVEL_INIT, cpu_init_crit is always compilled. This is for arm926ejs module.

I'm not sure about this one. Probably the whole cpu_init_crit: part should be placed inside the "#ifndef CONFIG_SKIP_LOWLEVEL_INIT" part, as it is done for example in "cpu/arm920t/start.S" ?

Not applied.

Best regards,

Wolfgang Denk

Signature · 2 lines

View this message in context: http://www.nabble.com/-PATCH--ARM926%3A-compile-cpu_init_crit-function-only-if-CONFIG_SKIP_LOWLEVEL_INIT-is-not-defined-tp14408413p15281823.html
Sent from the Uboot - Users mailing list archive at Nabble.com.

Wolfgang Denk

2008-02-13 23:59 UTC #5 lore raw

PATCH 1/1 ARM926: compile cpu_init_crit function only if CONFIG_SKIP_LOWLEVEL_INIT is not defined

Quoted 4 lines · In message <[email protected]> you wrote:

At Present the call to "cpu_init_crit" in uboot/cpu/arm926ejs/start.S (142) is under ifndef

Quoted 8 lines

#ifndef CONFIG_SKIP_LOWLEVEL_INIT
bl cpu_init_crit
#endif
But the function definition (203) isn't under this ifndef. So irrespective
of CONFIG_SKIP_LOWLEVEL_INIT, this function is compiled. Hence i have applied the ifndef to function definition which places the entire cpu_init_crit inside the ifndef.

I don't think you answer my question:

Quoted 3 lines

I'm not sure about this one. Probably the whole cpu_init_crit: part should be placed inside the "#ifndef CONFIG_SKIP_LOWLEVEL_INIT" part, as it is done for example in "cpu/arm920t/start.S" ?

Best regards,

Wolfgang Denk

Signature · 6 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The years of peak mental activity are undoubtedly between the ages of
four and eighteen. At four we know all the questions, at eighteen all
the answers.

Hebbar

author

2008-02-14 00:19 UTC #6 lore raw

PATCH 1/1 ARM926: compile cpu_init_crit function only if CONFIG_SKIP_LOWLEVEL_INIT is not defined

Hi,

I went through "cpu/arm920t/start.S" file and found that this is what this patch is doing.

This patch places the entire cpu_init_crit function definition inside ifndef same as in arm920t/start.S.

Sorry if i havent understood you.

Present cpu/arm926ejs/start.S

_start_armboot:

	.word start_armboot

                                            -----> This is where i have

placed #ifndef CONFIG_SKIP_LOWLEVEL_INIT
/*
*************************************************************************
*
* CPU_init_critical registers
*
* setup important registers
* setup memory timing
*
*************************************************************************
*/

cpu_init_crit:

	/*
	 * flush v4 I/D caches
	 */
	mov	r0,

bl lowlevel_init /* go setup pll,mux,memory */
mov lr, ip /* restore link */
mov pc, lr /* back to my caller */
/*
----> here is the #endif
*************************************************************************
*
* Interrupt handling
*
*************************************************************************
*/

Regards
Gururaja

Quoted 17 lines · wd

In message <[email protected]> you wrote:
I don't think you answer my question:
Quoted 3 lines
I'm not sure about this one. Probably the whole cpu_init_crit: part should be placed inside the "#ifndef CONFIG_SKIP_LOWLEVEL_INIT" part, as it is done for example in "cpu/arm920t/start.S" ?
?
Best regards,
Wolfgang Denk

Signature · 2 lines

View this message in context: http://www.nabble.com/-PATCH--ARM926%3A-compile-cpu_init_crit-function-only-if-CONFIG_SKIP_LOWLEVEL_INIT-is-not-defined-tp14408413p15471298.html
Sent from the Uboot - Users mailing list archive at Nabble.com.