Mark board_init_[fr] as noreturn
PATCH 1/1 Mark board_init_[fr] as noreturn
--- include/common.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
include/common.h +2 -2
@@ -203,8 +203,8 @@ void init_cmd_timeout(void);void reset_cmd_timeout (void );/* lib_$(ARCH)/board.c */ -void board_init_f (ulong ); -void board_init_r (gd_t *,ulong ); +void board_init_f (ulong ) __attribute__ ((noreturn)); +void board_init_r (gd_t *,ulong ) __attribute__ ((noreturn));int checkboard (void );int checkflash (void );int checkdram (void );
Signature · 1 line
1.5.3.8
Wolfgang Denk
AppliedPATCH 1/1 Mark board_init_[fr] as noreturn
Quoted 4 lines · In message <[email protected]> you wrote:
Signed-off-by Mike Frysinger <[email protected]>--- include/common.h | 4 ++--
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Celestial navigation is based on the premise that the Earth is the center of the universe. The premise is wrong, but the navigation works. An incorrect model can be a useful tool. - Kelvin Throop III
PATCH 1/1 Mark board_init_[fr] as noreturn
In reply to Mike FrysingerQuoted 11 lines · In message <[email protected]> you wrote:
Signed-off-by Mike Frysinger <[email protected]>--- include/common.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)include/common.h +0
-0
include/common.h void init_cmd_timeout(void); · line 207
Quoted 7 lines
include/common.h +2
-2@@ -203,8 +203,8 @@ void init_cmd_timeout(void);void reset_cmd_timeout (void );/* lib_$(ARCH)/board.c */ -void board_init_f (ulong ); -void board_init_r (gd_t *,ulong ); +void board_init_f (ulong ) __attribute__ ((noreturn)); +void board_init_r (gd_t *,ulong ) __attribute__ ((noreturn));
Well - now I get compile warnings (on PPC):
board.c: In function 'board_init_f':
board.c:615: warning: 'noreturn' function does return
How to fix?
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de How much net work could a network work, if a network could net work?
PATCH 1/1 Mark board_init_[fr] as noreturn
Quoted 21 lines · Wolfgang Denk
Quoted 10 lines · In message <[email protected]> you wrote:
Signed-off-by Mike Frysinger <[email protected]>--- include/common.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)include/common.h +0
-0include/common.h void init_cmd_timeout(void); · line 207
Quoted 7 lines
include/common.h +2
-2@@ -203,8 +203,8 @@ void init_cmd_timeout(void);void reset_cmd_timeout (void );/* lib_$(ARCH)/board.c */ -void board_init_f (ulong ); -void board_init_r (gd_t *,ulong ); +void board_init_f (ulong ) __attribute__ ((noreturn)); +void board_init_r (gd_t *,ulong ) __attribute__ ((noreturn));Well - now I get compile warnings (on PPC):
Quoted 4 lines
board.c: In function 'board_init_f':
board.c:615: warning: 'noreturn' function does returnHow to fix?
your relocate_code() function prototype is missing a noreturn attribute -mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080214/21a3cbc2/attachment.pgp