Skip to contentSkip to conversation

markers: Fix build for MODULES=n.

PATCH In review Paul Mundt 2 participants 3 messages Feb 14, 2008 Module support

lore
Share & tools
lore

Paul Mundt

author
#0 lore raw

PATCH 1/1 markers: Fix build for MODULES=n.

CC kernel/marker.o
kernel/marker.c: In function 'marker_update_probes':
kernel/marker.c:627: error: too few arguments to function 'module_update_markers' make[1]: *** [kernel/marker.o] Error 1
make: *** [kernel] Error 2

module_update_markers() doesn't take any arguments, update the MODULES=n version of it to reflect that.

---

 include/linux/module.h |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
include/linux/module.h +1 -2
index 330bec0..819c4e8 100644
@@ -567,8 +567,7 @@ static inline void print_modules(void)
 {
 }
 
-static inline void module_update_markers(struct module *probe_module,
-		int *refcount)
+static inline void module_update_markers(void)
 {
 }
 
#1 lore raw
Quoted 9 lines · * Paul Mundt ([email protected]) wrote:

CC kernel/marker.o
kernel/marker.c: In function 'marker_update_probes':
kernel/marker.c:627: error: too few arguments to function 'module_update_markers' make[1]: *** [kernel/marker.o] Error 1
make: *** [kernel] Error 2

module_update_markers() doesn't take any arguments, update the MODULES=n version of it to reflect that.

Hi Paul, thanks for submitting this. Adrian-the-roadrunner has been faster than you though. :) He already submitted this fix here :

http://lkml.org/lkml/2008/2/13/714

Mathieu

Quoted 21 lines

---

 include/linux/module.h |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
include/linux/module.h +1 -2
index 330bec0..819c4e8 100644
@@ -567,8 +567,7 @@ static inline void print_modules(void)
 {
 }
 
-static inline void module_update_markers(struct module *probe_module,
-		int *refcount)
+static inline void module_update_markers(void)
 {
 }
 
Signature · 3 lines
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
author
#2 lore raw
Quoted 7 lines · Mathieu Desnoyers
Quoted 6 lines · * Paul Mundt ([email protected]) wrote:

CC kernel/marker.o
kernel/marker.c: In function 'marker_update_probes':
kernel/marker.c:627: error: too few arguments to function 'module_update_markers' make[1]: *** [kernel/marker.o] Error 1
make: *** [kernel] Error 2

Quoted 9 lines
Quoted 3 lines

module_update_markers() doesn't take any arguments, update the MODULES=n version of it to reflect that.

Hi Paul, thanks for submitting this. Adrian-the-roadrunner has been faster than you though. :) He already submitted this fix here :

http://lkml.org/lkml/2008/2/13/714

No worries, I was just tossing out stuff I hit with my randconfigs now that things are slowing down. It's difficult to verify your own stuff when the rest of the tree keeps breaking. It's good to know there are other people doing similar tests ;-)