Skip to contentSkip to conversation

IPMI: Remove unnecessary memory barriers

PATCH In review Corey Minyard 1 participant 1 message Feb 14, 2008 IPMI

lore
Share & tools
lore
#0 lore raw

PATCH 2/4 IPMI: Remove unnecessary memory barriers

From: Corey Minyard <[email protected]>

Remove some unnecessary barriers.

---
This can be folded into ipmi-dont-grab-locks-in-run-to-completion-mode.patch

drivers/char/ipmi/ipmi_msghandler.c +0 -2
Index: linux-2.6.24/drivers/char/ipmi/ipmi_msghandler.c
===================================================================
@@ -3518,7 +3518,6 @@ void ipmi_smi_msg_received(ipmi_smi_t   
 	/* To preserve message order, if the list is not empty, we
            tack this message onto the end of the list. */
 	run_to_completion = intf->run_to_completion;
-	barrier();
 	if (!run_to_completion)
 		spin_lock_irqsave(&intf->waiting_msgs_lock, flags);
 	if (!list_empty(&intf->waiting_msgs)) {
@@ -3535,7 +3534,6 @@ void ipmi_smi_msg_received(ipmi_smi_t   
 		/* Could not handle the message now, just add it to a
                    list to handle later. */
 		run_to_completion = intf->run_to_completion;
-		barrier();
 		if (!run_to_completion)
 			spin_lock_irqsave(&intf->waiting_msgs_lock, flags);
 		list_add_tail(&msg->link, &intf->waiting_msgs);