Skip to contentSkip to conversation

Fix {clear,copy}_user_page() declarations in page.h

PATCH New Chuck Lever 1 participant 1 message Feb 14, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix {clear,copy}_user_page() declarations in page.h

Clean up: eliminate some compiler noise on x86 when building with strict warnings enabled, introduced by commit 345b904c.

In file included from include2/asm/thread_info_64.h:12,
from include2/asm/thread_info.h:4, from
/home/cel/src/linux/nfs-2.6/include/linux/thread_info.h:35,
from
/home/cel/src/linux/nfs-2.6/include/linux/preempt.h:9,
from
/home/cel/src/linux/nfs-2.6/include/linux/spinlock.h:49,

                 from /home/cel/src/linux/nfs-2.6/include/linux/mmzone.h:7,
                 from /home/cel/src/linux/nfs-2.6/include/linux/gfp.h:4,
                 from /home/cel/src/linux/nfs-2.6/include/linux/slab.h:14,
                 from /home/cel/src/linux/nfs-2.6/fs/nfsd/nfs4acl.c:40:

include2/asm/page.h:55: warning: `inline' is not at beginning of declaration
include2/asm/page.h:61: warning: `inline' is not at beginning of declaration

Cc Jeremy Fitzhardinge <[email protected]>

---

 include/asm-x86/page.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
include/asm-x86/page.h +2 -2
index 1cb7c51..a05b289 100644
@@ -52,13 +52,13 @@ extern int page_is_ram(unsigned long pagenr);
 
 struct page;
 
-static void inline clear_user_page(void *page, unsigned long vaddr,
+static inline void clear_user_page(void *page, unsigned long vaddr,
 				struct page *pg)
 {
 	clear_page(page);
 }
 
-static void inline copy_user_page(void *to, void *from, unsigned long vaddr,
+static inline void copy_user_page(void *to, void *from, unsigned long vaddr,
 				struct page *topage)
 {
 	copy_page(to, from);