Skip to contentSkip to conversation

tftp warning/error?

U-Boot-Users New Kumar Gala 5 participants 7 messages Feb 13, 2008 – Feb 14, 2008 Networking

lore
Share & tools
lore

Kumar Gala

author
#0 lore raw

'TFTP: add host ip addr support' commit added this bit of code which seems bogus:

         } else {
                 char *p = strchr (p, ':');

Is this really correct?

- k

#1 lore raw
Quoted 7 lines · Kumar Gala

'TFTP: add host ip addr support' commit added this bit of code which seems bogus:

        } else {
                char *p = strchr (p, ':');

Is this really correct?

No, it this
- char *p = strchr (p, ':');
+ char *p = strchr (BootFile, ':');

Best Regards,
J.

#2 lore raw

PATCH 1/1 TFTP: fix search of ':' in BootFile

net/tftp.c +1 -1
index 3dd2b06..ea8fea2 100644
@@ -474,7 +474,7 @@ TftpStart (void)
 		printf ("*** Warning: no boot file name; using '%s'\n",
 			tftp_filename);
 	} else {
-		char *p = strchr (p, ':');
+		char *p = strchr (BootFile, ':');
 
 		if (p == NULL) {
 			strncpy(tftp_filename, BootFile, MAX_LEN);
Signature · 1 line
1.5.3.7
#3 lore raw

PATCH 1/1 TFTP: fix search of ':' in BootFile

Wolfgang,

Can you pick this up as its a clear bug fix.

- k

Quoted 28 lines · Jean-Christophe PLAGNIOL-VILLARD

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD
<[email protected]>

net/tftp.c +1 -1
index 3dd2b06..ea8fea2 100644
@@ -474,7 +474,7 @@ TftpStart (void)
 		printf ("*** Warning: no boot file name; using '%s'\n",
 			tftp_filename);
 	} else {
-		char *p = strchr (p, ':');
+		char *p = strchr (BootFile, ':');
 
 		if (p == NULL) {
 			strncpy(tftp_filename, BootFile, MAX_LEN);
Signature · 11 lines
1.5.3.7


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
#4 lore raw

PATCH 1/1 TFTP: fix search of ':' in BootFile

In reply to Jean-Christophe PLAGNIOL-VILLARD

net/tftp.c TftpStart (void) · line 477

Quoted 12 lines · In message <[email protected]> you wrote:
net/tftp.c +1 -1
index 3dd2b06..ea8fea2 100644
@@ -474,7 +474,7 @@ TftpStart (void)
 		printf ("*** Warning: no boot file name; using '%s'\n",
 			tftp_filename);
 	} else {
-		char *p = strchr (p, ':');
+		char *p = strchr (BootFile, ':');

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Bureaucracy is the enemy of innovation."
       - Mark Shepherd, former President and CEO of Texas Instruments
#5 lore raw

PATCH 1/1 TFTP: fix search of ':' in BootFile

In reply to Jean-Christophe PLAGNIOL-VILLARD
Quoted 7 lines · In message <[email protected]> you wrote:
net/tftp.c +0 -0
index 3dd2b06..ea8fea2 100644

net/tftp.c TftpStart (void) · line 480

Quoted 8 lines
net/tftp.c +1 -1
@@ -474,7 +474,7 @@ TftpStart (void)
 		printf ("*** Warning: no boot file name; using '%s'\n",
 			tftp_filename);
 	} else {
-		char *p = strchr (p, ':');
+		char *p = strchr (BootFile, ':');
 
 		if (p == NULL) {
 			strncpy(tftp_filename, BootFile, MAX_LEN);

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If only God would give me some clear sign! Like making a large  depo-
sit in my name at a Swiss Bank.                         - Woody Allen
#6 lore raw
In reply to Kumar Gala
Quoted 11 lines · Kumar Gala

'TFTP: add host ip addr support' commit added this bit of code which seems bogus:

         } else {
                 char *p = strchr (p, ':');

Is this really correct?

- k

That's F-d up. The patches I have are like this:

- tftp_filename = BootFile;
+ char *p=BootFile;
+ p = strchr (p, ':');

but never got pulled into the net branch. I guess Wolfgang must have pulled directly. C'mon patch management system!!!

cheers,
Ben