Skip to contentSkip to conversation

Do not specify a CROSS_COMPILE default when executing size

PATCH New Mike Frysinger 2 participants 4 messages Jan 28, 2008 – Feb 14, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Do not specify a CROSS_COMPILE default when executing size

---
 MAKEALL |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
MAKEALL +1 -1
index d66a5fa..2aff4da 100755
@@ -721,7 +721,7 @@ build_target() {
 	${MAKE} ${JOBS} all 2>&1 >${LOG_DIR}/$target.MAKELOG \
 				| tee ${LOG_DIR}/$target.ERR
 
-	${CROSS_COMPILE:-ppc_8xx-}size ${BUILD_DIR}/u-boot \
+	${CROSS_COMPILE}size ${BUILD_DIR}/u-boot \
 				| tee -a ${LOG_DIR}/$target.MAKELOG
 }
 
Signature · 1 line
1.5.3.8
#1 lore raw

PATCH 1/1 Do not specify a CROSS_COMPILE default when executing size

Quoted 11 lines · In message <[email protected]> you wrote:
---
 MAKEALL |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
MAKEALL +0 -0
index d66a5fa..2aff4da 100755

MAKEALL build_target() { · line 724

Quoted 5 lines
MAKEALL +1 -1
@@ -721,7 +721,7 @@ build_target() {
 	${MAKE} ${JOBS} all 2>&1 >${LOG_DIR}/$target.MAKELOG \
 				| tee ${LOG_DIR}/$target.ERR
 
-	${CROSS_COMPILE:-ppc_8xx-}size ${BUILD_DIR}/u-boot \
+	${CROSS_COMPILE}size ${BUILD_DIR}/u-boot \

What exactly is bad about using this default?

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A mouse is an elephant built by the Japanese.
#2 lore raw

PATCH 1/1 Do not specify a CROSS_COMPILE default when executing size

Quoted 13 lines · Wolfgang Denk
Quoted 12 lines · In message <[email protected]> you wrote:
---
 MAKEALL |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
MAKEALL +0 -0
index d66a5fa..2aff4da 100755
@@ -721,7 +721,7 @@ build_target() {
 	${MAKE} ${JOBS} all 2>&1 >${LOG_DIR}/$target.MAKELOG \
 
Quoted 6 lines

MAKEALL build_target() { · line 724

Quoted 4 lines
MAKEALL +1 -1
 				| tee ${LOG_DIR}/$target.ERR
 
-	${CROSS_COMPILE:-ppc_8xx-}size ${BUILD_DIR}/u-boot \
+	${CROSS_COMPILE}size ${BUILD_DIR}/u-boot \

What exactly is bad about using this default?

the default is useless for non-ppc systems ? try and run the MAKEALL script on a system that lacks ppc_8xx- and CROSS_COMPILE is not set and you get an error about ppc_8xx-size not existing and no useful output at all. imagine that.

here's a better question: why is ppc_8xx- a better default than size ? you cant build u-boot on a system that lacks a host compiler and it is unrealistic to cover the case where the host size does not exist.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080213/c999d065/attachment.pgp

#3 lore raw

PATCH 1/1 Do not specify a CROSS_COMPILE default when executing size

In reply to Mike Frysinger
Quoted 5 lines · In message <[email protected]> you wrote:
---
 MAKEALL |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
No problem is insoluble.
	-- Dr. Janet Wallace, "The Deadly Years", stardate 3479.4