Skip to contentSkip to conversation

let DEBUG_SECTION_MISMATCH depend on BROKEN

PATCH In review Adrian Bunk 2 participants 3 messages Feb 15, 2008 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 let DEBUG_SECTION_MISMATCH depend on BROKEN

The pattern for making a config option on purpose not available is a dependency on BROKEN.

---
79b6f4490cadd62b3601f653df8a27ec2295adf0 diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index a370fe8..9fad6da 100644

lib/Kconfig.debug +1 -1
@@ -81,7 +81,7 @@ config HEADERS_CHECK
 
 config DEBUG_SECTION_MISMATCH
 	bool "Enable full Section mismatch analysis"
-	depends on UNDEFINED
+	depends on BROKEN
 	help
 	  The section mismatch analysis checks if there are illegal
 	  references from one section to another section.
#1 lore raw
Quoted 2 lines · Adrian Bunk

The pattern for making a config option on purpose not available is a dependency on BROKEN.

BROKEN says that what is selected by the cofig option is broken.
This is not the case for DEBUG_SECTION_MISMATCH which is why it was made dependent on something else.

Sam

#2 lore raw
Quoted 7 lines · Sam Ravnborg
Quoted 2 lines · Adrian Bunk

The pattern for making a config option on purpose not available is a dependency on BROKEN.

BROKEN says that what is selected by the cofig option is broken.
This is not the case for DEBUG_SECTION_MISMATCH which is why it was made dependent on something else.

BROKEN is our pattern for "intentionally disabled".

I did really grep for UNDEFINED when I first saw it since it might as well have been some kind of CONFIG_UNDEFINED "warn about undefined foobar".

Quoted 1 line

Sam

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed