Skip to contentSkip to conversation

building e2fsprogs-interim

PATCH In review Eric Sandeen 3 participants 4 messages Feb 14, 2008 – Feb 16, 2008

lore
Share & tools
lore

Eric Sandeen

author
#0 lore raw

PATCH 1/1 building e2fsprogs-interim

I needed this patch to build e2fsprogs-interim, to fix a parallel make problem

Signed-off-by Eric Sandeen <[email protected]>

---

lib/ext2fs/Makefile.in +1 -1
Index: e2fsprogs-1.40.6/lib/ext2fs/Makefile.in
===================================================================
@@ -518,7 +518,7 @@ mkdir.o: $(srcdir)/mkdir.c $(srcdir)/ext
  $(top_builddir)/lib/ext2fs/ext2_types.h $(srcdir)/ext2fs.h \
  $(srcdir)/ext2_fs.h $(srcdir)/ext3_extents.h $(top_srcdir)/lib/et/com_err.h \
  $(srcdir)/ext2_io.h $(top_builddir)/lib/ext2fs/ext2_err.h $(srcdir)/bitops.h
-mmp.o: $(srcdir)/ext2_fs.h $(srcdir)/ext2fs.h
+mmp.o: $(srcdir)/ext2_fs.h $(srcdir)/ext2fs.h $(top_builddir)/lib/ext2fs/ext2_err.h
 mkjournal.o: $(srcdir)/mkjournal.c $(srcdir)/ext2_fs.h \
  $(top_builddir)/lib/ext2fs/ext2_types.h $(top_srcdir)/lib/e2p/e2p.h \
  $(srcdir)/ext2_fs.h $(srcdir)/ext2fs.h $(srcdir)/ext3_extents.h \
#1 lore raw
Quoted 1 line · Eric Sandeen

I needed this patch to build e2fsprogs-interim, to fix a parallel make problem

Thanks, I've added to our CVS in case we ever have to re-submit the patch.

Quoted 19 lines
Signed-off-by Eric Sandeen <[email protected]>

---

Index: e2fsprogs-1.40.6/lib/ext2fs/Makefile.in
===================================================================

lib/ext2fs/Makefile.in +1 -2
@@ -518,7 +518,7 @@ mkdir.o: $(srcdir)/mkdir.c $(srcdir)/ext
  $(top_builddir)/lib/ext2fs/ext2_types.h $(srcdir)/ext2fs.h \
  $(srcdir)/ext2_fs.h $(srcdir)/ext3_extents.h $(top_srcdir)/lib/et/com_err.h \
  $(srcdir)/ext2_io.h $(top_builddir)/lib/ext2fs/ext2_err.h $(srcdir)/bitops.h
-mmp.o: $(srcdir)/ext2_fs.h $(srcdir)/ext2fs.h
+mmp.o: $(srcdir)/ext2_fs.h $(srcdir)/ext2fs.h $(top_builddir)/lib/ext2fs/ext2_err.h
 mkjournal.o: $(srcdir)/mkjournal.c $(srcdir)/ext2_fs.h \
  $(top_builddir)/lib/ext2fs/ext2_types.h $(top_srcdir)/lib/e2p/e2p.h \
  $(srcdir)/ext2_fs.h $(srcdir)/ext2fs.h $(srcdir)/ext3_extents.h \
 
 
-
Quoted 3 lines

To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.

author
#2 lore raw

Re: [PATCH] UPDATED: building e2fsprogs-interim

In reply to Eric Sandeen
Quoted 7 lines · Eric Sandeen

I needed this patch to build e2fsprogs-interim, to fix a parallel make problem

Signed-off-by Eric Sandeen <[email protected]>

---

An update; running through the whole fedora build turned up another one (csum.o). Out of curiosity do things like ext2_fs.h (which are not generated) really need to be listed as dependencies?

Signed-off-by Eric Sandeen <[email protected]>

---

e2fsprogs/lib/ext2fs/Makefile.in +4 -3
Index: e2fsprogs-git/e2fsprogs/lib/ext2fs/Makefile.in
===================================================================
@@ -390,8 +390,8 @@ crc16.o: $(srcdir)/crc16.c $(srcdir)/ext
  $(top_builddir)/lib/ext2fs/ext2_types.h $(srcdir)/ext2fs.h $(srcdir)/ext2_fs.h
 crc32.o: $(srcdir)/crc32.c $(srcdir)/ext2_fs.h $(srcdir)/crc16.h \
  $(top_builddir)/lib/ext2fs/ext2_types.h $(srcdir)/ext2fs.h $(srcdir)/ext2_fs.h
-csum.o: $(srcdir)/csum.c $(srcdir)/ext2_fs.h \
- $(top_builddir)/lib/ext2fs/ext2_types.h $(srcdir)/ext2fs.h $(srcdir)/ext2_fs.h
+csum.o: $(srcdir)/csum.c $(srcdir)/ext2_fs.h $(srcdir)/ext2fs.h \
+ $(top_builddir)/lib/ext2fs/ext2_types.h $(top_builddir)/lib/ext2fs/ext2_err.h
 dblist.o: $(srcdir)/dblist.c $(srcdir)/ext2_fs.h \
  $(top_builddir)/lib/ext2fs/ext2_types.h $(srcdir)/ext2fsP.h \
  $(srcdir)/ext2fs.h $(srcdir)/ext2_fs.h $(srcdir)/ext3_extents.h \

@@ -518,7 +518,8 @@ mkdir.o: $(srcdir)/mkdir.c $(srcdir)/ext
  $(top_builddir)/lib/ext2fs/ext2_types.h $(srcdir)/ext2fs.h \
  $(srcdir)/ext2_fs.h $(srcdir)/ext3_extents.h $(top_srcdir)/lib/et/com_err.h \
  $(srcdir)/ext2_io.h $(top_builddir)/lib/ext2fs/ext2_err.h $(srcdir)/bitops.h
-mmp.o: $(srcdir)/ext2_fs.h $(srcdir)/ext2fs.h
+mmp.o: $(srcdir)/ext2_fs.h $(srcdir)/ext2fs.h \
+ $(top_builddir)/lib/ext2fs/ext2_err.h
 mkjournal.o: $(srcdir)/mkjournal.c $(srcdir)/ext2_fs.h \
  $(top_builddir)/lib/ext2fs/ext2_types.h $(top_srcdir)/lib/e2p/e2p.h \
  $(srcdir)/ext2_fs.h $(srcdir)/ext2fs.h $(srcdir)/ext3_extents.h \
#3 lore raw

Re: [PATCH] UPDATED: building e2fsprogs-interim

Quoted 3 lines · Eric Sandeen

An update; running through the whole fedora build turned up another one (csum.o). Out of curiosity do things like ext2_fs.h (which are not generated) really need to be listed as dependencies?

Well, in an RPM build you probably don't need them, no.

But they are useful in an developer tree because if ext2_fs.h gets modified, it's good to recompile all source files that include it --- just to make sure any errors in the header file get caught.

- Ted