ServerEngines 10Gb NIC driver
Subsystems (2)
cover ServerEngines 10Gb NIC driver
Patch 0/16 and 15/16 of this series are getting dropped by the spam filter. I am trying to get them across with changes that will please the spam filter. Sorry about the inconvenience. Below is the 0/16 of the series.
--------------------------
Hi,
I am sending a patch for network driver for ServerEngines 10Gb Network adapter for review. This patch includes the network driver and the OS neutral code that implements the interactions between the host drivers and the adapter. The adapter is a dual function device with network and storage functions. The network driver is a regular NIC driver.
The low level library that manages the interaction with the adapter is common to both storage and network drivers and hence is organized under the directory drivers/message/beclib. The storage driver is not part of this patch and will be submitted after this review.
This patch is made against 2.6.24.2 version of the kernel source.
Thank you.
Subbu Seetharaman
------------------------
drivers/net/benet/be.h 373drivers/net/benet/bni.h 374drivers/net/benet/be_init.c 1426drivers/net/benet/be_netif.c 600drivers/net/benet/be_int.c 1254drivers/net/benet/be_tx.c 191drivers/net/benet/bni.c 1506drivers/net/benet/be_ethtool.c 410drivers/net/benet/be_proc.c 679drivers/net/benet/Makefile 25drivers/net/Kconfig 15drivers/net/Makefile 1MAINTAINERS 6drivers/message/beclib/pch.h 58
drivers/message/beclib/beclib_common.h 111 drivers/message/beclib/beclib_ll.h 682 drivers/message/beclib/beclib_private_ll.h 451
drivers/message/beclib/beclib_stats.h 73drivers/message/beclib/beclib_ll_enum_nic.h 68drivers/message/beclib/beclib_ll_bmap_nic.h 1720drivers/message/beclib/bestatus.h 129drivers/message/beclib/beregister.h 366drivers/message/beclib/main_ll.c 53drivers/message/beclib/chipobj_ll.c 145drivers/message/beclib/funcobj_ll.c 2339drivers/message/beclib/ethtx_ll.c 61drivers/message/beclib/ethrx_ll.c 430drivers/message/beclib/rxf_ll.c 1008drivers/message/beclib/eq_ll.c 751drivers/message/beclib/cq_ll.c 443drivers/message/beclib/mpu_ll.c 1559drivers/message/beclib/sa/setypes.h 70drivers/message/beclib/sa/sa.c 278drivers/message/beclib/sa/sa.h 1004
drivers/message/beclib/fw/amap/ioctl_opcodes.h 812 drivers/message/beclib/fw/amap/ioctl_defs.h 115 drivers/message/beclib/fw/amap/host_struct.h 115
drivers/message/beclib/fw/amap/be_common.h 86drivers/message/beclib/fw/amap/ep.h 99drivers/message/beclib/fw/amap/descriptors.h 105drivers/message/beclib/fw/amap/be_cm.h 110drivers/message/beclib/fw/amap/headers.h 84drivers/message/beclib/fw/amap/ioctl_top.h 63drivers/message/beclib/fw/amap/ioctl_types.h 459drivers/message/beclib/fw/amap/ioctl_common.h 260
drivers/message/beclib/fw/amap/mpu_context.h 56 drivers/message/beclib/fw/amap/ioctl_eth.h 95 drivers/message/beclib/fw/amap/etx_context.h 87 drivers/message/beclib/fw/amap/cev.h 275 drivers/message/beclib/fw/amap/asyncmesg.h 98 drivers/message/beclib/fw/amap/mpu.h 107 drivers/message/beclib/fw/amap/doorbells.h 211 drivers/message/beclib/fw/amap/ioctl_mcc.h 128 drivers/message/beclib/fw/amap/ioctl_hdr.h 58 drivers/message/beclib/fw/amap/regmap.h 100 drivers/message/beclib/fw/amap/common_context.h 73 drivers/message/beclib/fw/amap/post_codes.h 127 drivers/message/beclib/fw/be_gen_id_ranges.h 240 drivers/message/beclib/fw/bmap/ioctl_types_bmap.h 521 drivers/message/beclib/fw/bmap/etx_context_bmap.h 118 drivers/message/beclib/fw/bmap/host_struct_bmap.h 254 drivers/message/beclib/fw/bmap/doorbells_bmap.h 470 drivers/message/beclib/fw/bmap/mpu_bmap.h 155 drivers/message/beclib/fw/bmap/asyncmesg_bmap.h 158 drivers/message/beclib/fw/bmap/be_common_bmap.h 150 drivers/message/beclib/fw/bmap/ioctl_common_bmap.h 1398 drivers/message/beclib/fw/bmap/ep_bmap.h 175 drivers/message/beclib/fw/bmap/cev_bmap.h 552 drivers/message/beclib/fw/bmap/be_cm_bmap.h 174 drivers/message/beclib/fw/bmap/iscsi_initiator_host_struct_bmap.h 642 drivers/message/beclib/fw/bmap/descriptors_bmap.h 124 drivers/message/beclib/fw/bmap/regmap_bmap.h 204 drivers/message/beclib/fw/bmap/ioctl_hdr_bmap.h 87 drivers/message/beclib/fw/bmap/ioctl_top_bmap.h 61 drivers/message/beclib/fw/bmap/pcicfg_bmap.h 2333 drivers/message/beclib/fw/bmap/iscsi_common_host_struct_bmap.h 406 drivers/message/beclib/fw/bmap/mpu_context_bmap.h 102 drivers/message/beclib/fw/bmap/ioctl_eth_bmap.h 378 drivers/message/beclib/fw/bmap/ioctl_mcc_bmap.h 113 drivers/message/beclib/fw/bmap/post_codes_bmap.h 101
___________________________________________________________________________________
This message, together with any attachment(s), contains confidential and proprietary information of ServerEngines Corporation and is intended only for the designated recipient(s) named above. Any unauthorized review, printing, retention, copying, disclosure or distribution is strictly prohibited. If you are not the intended recipient of this message, please immediately advise the sender by reply email message and delete all copies of this message and any attachment(s). Thank you.
Quoted 9 lines · Subbu Seetharaman
Patch 0/16 and 15/16 of this series are getting dropped by the spam filter. I am trying to get them across with changes that will please the spam filter. Sorry about the inconvenience. Below is the 0/16 of the series.
--------------------------
Hi,
Quoted 5 lines
I am sending a patch for network driver for ServerEngines 10Gb Network adapter for review. This patch includes the network driver and the OS neutral code that implements the interactions between the host drivers and the adapter. The adapter is a dual function device with network and storage functions. The network driver is a regular NIC driver.
The low level library that manages the interaction with the adapter is common to both storage and network drivers and hence is organized under the directory
drivers/message/beclib. The storage driver is not part of this patch and will be submitted after this review.This patch is made against 2.6.24.2 version of the kernel source.
Hi Subbu.
A few points about your submission (not your code as I have not looked at it).
- Use descriptive subjects - and not the same subject for all patches
- Include in each patch a diffstat - below the '^---' marker so
it is easy to spot what files are touched but so that the diffstat does not get included in the changelog when applied.
- Do not break the build. Adding Makefile/Kconfig bits as the last patch usually does the trick here.
- If you have generic funtionality add that first and then add what depnds on it later.
Sam
Quoted 28 lines · Sam Ravnborg
Quoted 9 lines · Subbu Seetharaman
Patch 0/16 and 15/16 of this series are getting dropped by the spam filter. I am trying to get them across with changes that will please the spam filter. Sorry about the inconvenience. Below is the 0/16 of the series.
--------------------------
Hi,Quoted 5 lines
I am sending a patch for network driver for ServerEngines 10Gb Network adapter for review. This patch includes the network driver and the OS neutral code that implements the interactions between the host drivers and the adapter. The adapter is a dual function device with network and storage functions. The network driver is a regular NIC driver.
The low level library that manages the interaction with the adapter is common to both storage and network drivers and hence is organized under the directory
drivers/message/beclib. The storage driver is not part of this patch and will be submitted after this review.This patch is made against 2.6.24.2 version of the kernel source.
Hi Subbu.
A few points about your submission (not your code as I have not looked at it).
- Use descriptive subjects - and not the same subject for all patches
- Include in each patch a diffstat - below the '^---' marker so
it is easy to spot what files are touched but so that the diffstat does not get included in the changelog when applied.
- Do not break the build. Adding Makefile/Kconfig bits as the last patch usually does the trick here.
- If you have generic funtionality add that first and then add what depnds on it later.
Quoted 1 line
Sam
I just tried scripts/checkpatch.pl - it said:
total: 250 errors, 837 warnings, 31889 lines checked
That was for the full patch-set.
I suggest you look into these. The goal is not to get down on 0/0 but close with some common sense applied.
Sam