Skip to contentSkip to conversation

ext3: check ext3_journal_get_write_access() errors

PATCH In review Akinobu Mita 1 participant 1 message Feb 17, 2008

lore
Share & tools
lore

Akinobu Mita

author
#0 lore raw

PATCH 4/4 ext3: check ext3_journal_get_write_access() errors

Check ext3_journal_get_write_access() errors.

Signed-off-by Akinobu Mita <[email protected]>
Cc Stephen Tweedie <[email protected]>
Cc [email protected]
Cc Andrew Morton <[email protected]>
---
 fs/ext3/namei.c |    9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
fs/ext3/namei.c +7 -2
Index: 2.6-rc/fs/ext3/namei.c
===================================================================
@@ -57,10 +57,15 @@ static struct buffer_head *ext3_append(h
 
 	*block = inode->i_size >> inode->i_sb->s_blocksize_bits;
 
-	if ((bh = ext3_bread(handle, inode, *block, 1, err))) {
+	bh = ext3_bread(handle, inode, *block, 1, err);
+	if (bh) {
 		inode->i_size += inode->i_sb->s_blocksize;
 		EXT3_I(inode)->i_disksize = inode->i_size;
-		ext3_journal_get_write_access(handle,bh);
+		*err = ext3_journal_get_write_access(handle, bh);
+		if (*err) {
+			brelse(bh);
+			bh = NULL;
+		}
 	}
 	return bh;
 }