Skip to contentSkip to conversation

maple: add driver for Sega Dreamcast controller

PATCH In review Adrian McMenamin 2 participants 2 messages Feb 16, 2008 – Feb 18, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 maple: add driver for Sega Dreamcast controller

Add support for the SEGA Dreamcast controller as a joystick device. Based on Yaegashi Takeshi's old 2.4 driver (never in mainline) with the addition of functioning removal (and reinsertion) code.

---

drivers/input/joystick/Kconfig +13 -0
diff -ruN a/drivers/input/joystick/Kconfig b/drivers/input/joystick/Kconfig
@@ -282,4 +282,17 @@
 	  This option enables support for the LED which surrounds the Big X on
 	  XBox 360 controller.
 
+config JOYSTICK_MAPLE
+	tristate "Dreamcast control pad"
+	depends on SH_DREAMCAST
+	select MAPLE
+	help
+	  Say Y here if you have a SEGA Dreamcast and want to use your
+	  controller.
+
+	  Most Dreamcast users will say Y.
+
+	  To compile this as a module choose M here: the
+	  module will be called maplecontrol.
+
 endif
drivers/input/joystick/Makefile +1 -0
diff -ruN a/drivers/input/joystick/Makefile b/drivers/input/joystick/Makefile
@@ -27,5 +27,6 @@
 obj-$(CONFIG_JOYSTICK_TWIDJOY)		+= twidjoy.o
 obj-$(CONFIG_JOYSTICK_WARRIOR)		+= warrior.o
 obj-$(CONFIG_JOYSTICK_XPAD)		+= xpad.o
+obj-$(CONFIG_JOYSTICK_MAPLE)		+= maplecontrol.o
 
 obj-$(CONFIG_JOYSTICK_IFORCE)		+= iforce/
drivers/input/joystick/maplecontrol.c +246 -0

246 lines not on this page · raw message

#1 lore raw

drivers/input/joystick/maplecontrol.c line 40

Quoted 13 lines · On Sat, 16 Feb 2008 23:50:15 +0000 Adrian McMenamin…

Add support for the SEGA Dreamcast controller as a joystick device. Based on Yaegashi Takeshi's old 2.4 driver (never in mainline) with the addition of functioning removal (and reinsertion) code.

...

drivers/input/joystick/maplecontrol.c +9 -0
+static void dc_pad_callback(struct mapleq *mq)
+{
+	unsigned short buttons;
+	struct maple_device *mapledev = mq->dev;
+	struct dc_pad *pad = mapledev->private_data;
+	struct input_dev *dev = pad->dev;
+	unsigned char *res = mq->recvbuf;
+
+	buttons = ~*(unsigned short *)(res+8);

This is endianness-dependent. Presumably it "works", but it's pretty poor practice.

Quoted 76 lines

...

Quoted 1 line

+static int dc_pad_connect(struct maple_device *mdev)

drivers/input/joystick/maplecontrol.c +73 -0
+{
+	int i, error;
+	unsigned long data = be32_to_cpu(mdev->devinfo.function_data[0]);
+	struct dc_pad *pad;
+	struct input_dev *dev;
+
+	const short btn_bit[32] = {
+		BTN_C, BTN_B, BTN_A, BTN_START, -1, -1, -1, -1,
+		BTN_Z, BTN_Y, BTN_X, BTN_SELECT, -1, -1, -1, -1,
+		-1, -1, -1, -1, -1, -1, -1, -1,
+		-1, -1, -1, -1, -1, -1, -1, -1,
+	};
+
+	const short abs_bit[32] = {
+		-1, -1, -1, -1, ABS_HAT0Y, ABS_HAT0Y, ABS_HAT0X, ABS_HAT0X,
+		-1, -1, -1, -1, ABS_HAT1Y, ABS_HAT1Y, ABS_HAT1X, ABS_HAT1X,
+		ABS_GAS, ABS_BRAKE, ABS_X, ABS_Y, ABS_RX, ABS_RY, -1, -1,
+		-1, -1, -1, -1, -1, -1, -1, -1,
+	};
+
+	pad = kzalloc(sizeof(struct dc_pad), GFP_KERNEL);
+	if (!pad)
+		return -ENOMEM;
+
+	dev = input_allocate_device();
+	if (!dev) {
+		kfree(pad);
+		return -ENOMEM;
+	}
+
+	pad->dev = dev;
+	pad->mdev = mdev;
+	mdev->private_data = pad;
+
+	for (i = 0; i < 32; i++)
+		if (data & (1<<i) && btn_bit[i] >= 0)
+			pad->dev->keybit[BTN_JOYSTICK/32] |= BIT(btn_bit[i]);
+
+	if (pad->dev->keybit[BTN_JOYSTICK/32])
+		pad->dev->evbit[0] |= BIT(EV_KEY);
+
+	for (i = 0; i < 32; i++)
+		if (data & (1<<i) && abs_bit[i] >= 0)
+			pad->dev->absbit[0] |= BIT(abs_bit[i]);
+
+	if (pad->dev->absbit[0])
+		pad->dev->evbit[0] |= BIT(EV_ABS);
+
+	for (i = ABS_X; i <= ABS_BRAKE; i++) {
+		pad->dev->absmax[i] = 255;
+		pad->dev->absmin[i] = 0;
+		pad->dev->absfuzz[i] = 0;
+		pad->dev->absflat[i] = 0;
+	}
+
+	for (i = ABS_HAT0X; i <= ABS_HAT3Y; i++) {
+		pad->dev->absmax[i] = 1;
+		pad->dev->absmin[i] = -1;
+		pad->dev->absfuzz[i] = 0;
+		pad->dev->absflat[i] = 0;
+	}
+
+	pad->dev->open = dc_pad_open;
+	pad->dev->close = dc_pad_close;
+	pad->dev->private = pad;
+	pad->dev->event = NULL;
+	pad->dev->dev.parent = &mdev->dev;
+	pad->dev->name = mdev->product_name;
+	pad->dev->id.bustype = BUS_HOST;
+	input_set_drvdata(dev, pad);
+
+	error = input_register_device(pad->dev);
+	if (error) {

drivers/input/joystick/maplecontrol.c line 175

Quoted 10 lines
drivers/input/joystick/maplecontrol.c +10 -0
+		input_free_device(pad->dev);
+		kfree(pad);
+		return -error;
+	}
+
+	maple_getcond_callback(mdev, dc_pad_callback_idle, 0xFFFFFFFF,
+		MAPLE_FUNC_CONTROLLER);
+
+	return 0;
+}

The error handling in here would be more maintainable if it were to use the usual `goto err_foo' approach - aim for only a single return statement per function.