Skip to contentSkip to conversation

queue usb USB_CDC_GET_ENCAPSULATED_RESPONSE message

PATCH In review Jan Altenberg 2 participants 2 messages Feb 19, 2008 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 queue usb USB_CDC_GET_ENCAPSULATED_RESPONSE message

Hi all,

commit 0cf4f2de0a0f4100795f38ef894d4910678c74f8 introduced a bug, which prevents sending an USB_CDC_GET_ENCAPSULATED_RESPONSE message. This breaks the RNDIS initialization (especially / only Windoze machines dislike this behavior...).

---
 drivers/usb/gadget/ether.c |    1 +
 1 file changed, 1 insertion(+)
drivers/usb/gadget/ether.c +1 -0
Index: linux-2.6.24/drivers/usb/gadget/ether.c
===================================================================
@@ -1568,6 +1568,7 @@ done_set_intf:
 				memcpy(req->buf, buf, n);
 				req->complete = rndis_response_complete;
 				rndis_free_response(dev->rndis_config, buf);
+				value = n;
 			}
 			/* else stalls ... spec says to avoid that */
 		}
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Jan Altenberg

Hi all,

commit 0cf4f2de0a0f4100795f38ef894d4910678c74f8 introduced a bug, which prevents sending an USB_CDC_GET_ENCAPSULATED_RESPONSE message. This breaks the RNDIS initialization (especially / only Windoze machines dislike this behavior...).

Quoted 18 lines
---
 drivers/usb/gadget/ether.c |    1 +
 1 file changed, 1 insertion(+)

Index: linux-2.6.24/drivers/usb/gadget/ether.c
===================================================================

drivers/usb/gadget/ether.c +1 -0
@@ -1568,6 +1568,7 @@ done_set_intf:
 				memcpy(req->buf, buf, n);
 				req->complete = rndis_response_complete;
 				rndis_free_response(dev->rndis_config, buf);
+				value = n;
 			}
 			/* else stalls ... spec says to avoid that */
 		}