dlm: match signedness between dlm_config_info and cluster_set
PATCH 1/1 dlm: match signedness between dlm_config_info and cluster_set
cluster_set is only called from the macro CLUSTER_ATTR which defines read/write access functions. Make the signedness match to avoid sparse warnings every time CLUSTER_ATTR is used (lines 149-159) all of the form:
fs/dlm/config.c:149:1: warning: incorrect type in argument 3 (different signedness)fs/dlm/config.c:149:1: expected unsigned int *info_fieldfs/dlm/config.c:149:1: got int extern [toplevel] *<noident>
--- fs/dlm/config.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
fs/dlm/config.c +1 -1
@@ -114,7 +114,7 @@ struct cluster_attribute { };static ssize_t cluster_set (struct cluster *cl,unsigned int *cl_field, -unsigned int *info_field,int check_zero, +int *info_field,int check_zero,const char *buf,size_t len) {unsigned int x;
Signature · 1 line
1.5.4.1.1278.gc75be
David Teigland
maintainerQuoted 9 lines · Harvey Harrison
cluster_setis only called from the macroCLUSTER_ATTRwhich defines read/write access functions. Make the signedness match to avoid sparse warnings every timeCLUSTER_ATTRis used (lines 149-159) all of the form:
fs/dlm/config.c:149:1: warning: incorrect type in argument 3 (different signedness)fs/dlm/config.c:149:1: expected unsigned int*info_fieldfs/dlm/config.c:149:1: got int extern [toplevel] *<noident>Signed-off-by Harvey Harrison <[email protected]>
Thanks, added to dlm.git.
Dave