Skip to contentSkip to conversation

Fix fdt boardsetup command parsing

PATCH Superseded Kumar Gala 2 participants 3 messages Feb 20, 2008

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Kumar Gala

author
#0 lore raw

PATCH 1/1 Fix fdt boardsetup command parsing

The introduciton of the 'fdt bootcpu' broke parsing for 'fdt boardsetup'.

---
 common/cmd_fdt.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
common/cmd_fdt.c +2 -1
index c31560b..26f09ad 100644
@@ -324,7 +324,8 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
 	/********************************************************************
 	 * Set boot cpu id
 	 ********************************************************************/
-	} else if ((argv[1][0] == 'b') && (argv[1][1] == 'o')) {
+	} else if ((argv[1][0] == 'b') && (argv[1][1] == 'o') &&
+		   (argv[1][0] == 'o')) {
 		unsigned long tmp = simple_strtoul(argv[2], NULL, 16);
 		fdt_set_boot_cpuid_phys(fdt, tmp);
 
Signature · 1 line
1.5.4.1
#1 lore raw

PATCH 1/1 Fix fdt boardsetup command parsing

common/cmd_fdt.c int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[]) · line 328

Quoted 2 lines · On Wed, 20 Feb 2008 14:05:33 -0600 (CST) Kumar Gala…
common/cmd_fdt.c +2 -0
+	} else if ((argv[1][0] == 'b') && (argv[1][1] == 'o') &&
+		   (argv[1][0] == 'o')) {

don't you mean argv[1][2] here?

Kim

author
#2 lore raw

PATCH 1/1 Fix fdt boardsetup command parsing

Quoted 7 lines · Kim Phillips

common/cmd_fdt.c int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[]) · line 328

Quoted 2 lines · On Wed, 20 Feb 2008 14:05:33 -0600 (CST) Kumar Gala…
common/cmd_fdt.c +2 -0
+	} else if ((argv[1][0] == 'b') && (argv[1][1] == 'o') &&
+		   (argv[1][0] == 'o')) {

don't you mean argv[1][2] here?

gah.. just seeing if anyone is looking at these patches :)

- k