Skip to contentSkip to conversation

68360serial: Note that there isn't any info->mcr locking

PATCH New Alan Cox 1 participant 1 message Feb 20, 2008

lore
Share & tools
lore

Alan Cox

author
#0 lore raw

PATCH 1/1 68360serial: Note that there isn't any info->mcr locking

Noticed while auditing the code for the BKL elimination project

drivers/serial/68360serial.c +1 -1
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.25-rc2-mm1/drivers/serial/68360serial.c linux-2.6.25-rc2-mm1/drivers/serial/68360serial.c
@@ -1281,7 +1281,7 @@
 
 	if (tty->flags & (1 << TTY_IO_ERROR))
 		return -EIO;
-
+	/* FIXME: locking on info->mcr */
  	if (set & TIOCM_RTS)
  		info->mcr |= UART_MCR_RTS;
  	if (set & TIOCM_DTR)