Skip to contentSkip to conversation

fs: removing unused fops from struct char_device_struct

PATCH In review Jiri Olsa 2 participants 4 messages Feb 20, 2008 – Feb 21, 2008

Subsystems (2)
lore
Share & tools
lore

Jiri Olsa

author
#0 lore raw

PATCH 1/1 fs: removing unused fops from struct char_device_struct

Hi,

seems struct char_device_struct::fops is no longer used, removing it. I checked with "make allyesconfig" and got proper compile.

---
 fs/char_dev.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
fs/char_dev.c +0 -1
index c3bfa76..e4527fb 100644
@@ -55,7 +55,6 @@ static struct char_device_struct {
 	unsigned int baseminor;
 	int minorct;
 	char name[64];
-	struct file_operations *fops;
 	struct cdev *cdev;		/* will die */
 } *chrdevs[CHRDEV_MAJOR_HASH_SIZE];
 
#1 lore raw
Quoted 6 lines · Jiri Olsa

Hi,

seems struct char_device_struct::fops is no longer used, removing it. I checked with "make allyesconfig" and got proper compile.

Hm, why send this to me?

Did I make the mistake of touching this file last? Hm, nope, someone else touched it after I did, I'm safe :)

Seriously, I have no problem with this, but it should probably go through Andrew.

thanks,

greg k-h

author
#2 lore raw

oops, sorry... for some reason I though you were the guy :) I'll resend

jirka

Quoted 20 lines · Greg KH
Quoted 6 lines · Jiri Olsa

Hi,

seems struct char_device_struct::fops is no longer used, removing it. I checked with "make allyesconfig" and got proper compile.

Hm, why send this to me?

Did I make the mistake of touching this file last? Hm, nope, someone else touched it after I did, I'm safe :)

Seriously, I have no problem with this, but it should probably go through Andrew.

thanks,

greg k-h

author
#3 lore raw

PATCH 1/1 fs: removing unused fops from struct char_device_struct -

In reply to Jiri Olsa

Hi,

seems char_device_struct::fops is no longer used, removing it. I checked with "make allyesconfig" and got proper build.

---
 fs/char_dev.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
fs/char_dev.c +0 -1
index c3bfa76..e4527fb 100644
@@ -55,7 +55,6 @@ static struct char_device_struct {
 	unsigned int baseminor;
 	int minorct;
 	char name[64];
-	struct file_operations *fops;
 	struct cdev *cdev;		/* will die */
 } *chrdevs[CHRDEV_MAJOR_HASH_SIZE];