git-send-email getting filtered as spam by vger.kernel.org

From [email protected] Thu Feb 21 03:46:40 2008

git-send-email is getting filtered by vger.kernel.org

git --version
git version 1.5.4.2.184.gb23b

Example rejected message below.
sent this way:

git-send-email --from "Len Brown <[email protected]>" --compose --to [email protected] --smtp-server 192.168.0.6 --suppress-from --no-chain-reply-to patch-release

and then tried again with --chain-reply-to, but it also has not survived vger.kernel.org.

when it prompts "Message-ID to be used as In-Reply-To for the first email?" I simply hit return, b/c I have no idea how to answer that question.

This has worked for me many times in the past, but seems to have broken recently. I don't know if it was a change in git, or a change on vger.kernel.org.

clues?

thanks,
-Len

---------- Forwarded Message ----------

Subject: Fw: TABOO [email protected]: global taboo header: m/<>/ global taboo header: m/<>/
Date: Thursday 21 February 2008 03:56
From: David Miller <[email protected]>
To: [email protected]
Cc: [email protected]

All of your postings to the mailing list bounced because of those "<>" things in your headers. We block that because it is a pattern frequently used by spammers to cover up their Received headers.

...

Thanks.

-------------------------------------------------------

Quoted 1 line

From [email protected] Thu Feb 21 03:46:40 2008

Received: from mga09.intel.com ([134.134.136.24]:62635 "EHLO mga09.intel.com"

        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1755925AbYBUIqc (ORCPT <rfc822;[email protected]>);
        Thu, 21 Feb 2008 03:46:32 -0500

Received: from fmsmga002.fm.intel.com ([10.253.24.26])
by orsmga102.jf.intel.com with ESMTP; 21 Feb 2008 00:46:30 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="4.25,385,1199692800";
d="scan'208";a="300482149"
Received: from unknown (HELO localhost.localdomain) ([10.127.56.36])
by fmsmga002.fm.intel.com with ESMTP; 21 Feb 2008 00:44:45 -0800

From:   Len Brown <[email protected]>
To:     [email protected]

Cc: Henrique de Moraes Holschuh <[email protected]>,
Len Brown <[email protected]>
Subject: [PATCH 14/26] ACPI: thinkpad-acpi: make the video output feature optional
Date: Thu, 21 Feb 2008 03:45:16 -0500
Message-Id: <d7c1d17dfed996e84212fc1ce617b2586dd70ec2.1203581638.git.len.brown@intel.com>
X-Mailer: git-send-email 1.5.4.2.184.gb23b
In-Reply-To: <>
References: <>
In-Reply-To: <208c70a45624400fafd7511b96bc426bf01f8f5e.1203581637.git.len.brown@intel.com>
References: <208c70a45624400fafd7511b96bc426bf01f8f5e.1203581637.git.len.brown@intel.com>
Organization: Intel Open Source Technology Center
Return-Path: <[email protected]>
X-Envelope-To: <"|/opt/Majordomo/wrapper resend -l linux-acpi -f x-linux-acpi -h vger.kernel.org linux-acpi-outgoing"> (uid 400)
X-Orcpt: rfc822;[email protected]
Original-Recipient: rfc822;[email protected]

From: Henrique de Moraes Holschuh <[email protected]>

The video output port control feature is not very useful on many ThinkPads (especially when a X server is running), and lately userspace is getting better and better at it, so it makes sense to allow users to stripe out the thinkpad-acpi video feature from their kernels and save at least 2KB.

Signed-off-by Henrique de Moraes Holschuh <[email protected]>

Signed-off-by Len Brown <[email protected]>

---
 drivers/misc/Kconfig         |   17 +++++++++++++++++
 drivers/misc/thinkpad_acpi.c |   20 +++++++++++++-------
 2 files changed, 30 insertions(+), 7 deletions(-)

drivers/misc/Kconfig +17 -0

index 1abc95c..982e27b 100644
@@ -258,6 +258,23 @@ config THINKPAD_ACPI_BAY
 
          If you are not sure, say Y here.
 
+config THINKPAD_ACPI_VIDEO
+       bool "Video output control support"
+       depends on THINKPAD_ACPI
+       default y
+       ---help---
+         Allows the thinkpad_acpi driver to provide an interface to control
+         the various video output ports.
+
+         This feature often won't work well, depending on ThinkPad model,
+         display state, video output devices in use, whether there is a X
+         server running, phase of the moon, and the current mood of
+         Schroedinger's cat.  If you can use X.org's RandR to control
+         your ThinkPad's video output ports instead of this feature,
+         don't think twice: do it and say N here to save some memory.
+
+         If you are not sure, say Y here.
+
 config THINKPAD_ACPI_HOTKEY_POLL
        bool "Suport NVRAM polling for hot keys"
        depends on THINKPAD_ACPI

drivers/misc/thinkpad_acpi.c +13 -7

index 02f9465..4ea3866 100644
@@ -301,6 +301,13 @@ TPACPI_HANDLE(hkey, ec, "\\_SB.HKEY",      /* 600e/x, 770e, 770x */
           "HKEY",              /* all others */
           );                   /* 570 */
 
+TPACPI_HANDLE(vid, root, "\\_SB.PCI.AGP.VGA",  /* 570 */
+          "\\_SB.PCI0.AGP0.VID0",      /* 600e/x, 770x */
+          "\\_SB.PCI0.VID0",   /* 770e */
+          "\\_SB.PCI0.VID",    /* A21e, G4x, R50e, X30, X40 */
+          "\\_SB.PCI0.AGP.VID",        /* all others */
+          );                           /* R30, R31 */
+
 
 /*************************************************************************
  * ACPI helpers

@@ -2680,6 +2687,8 @@ static struct ibm_struct wan_driver_data = {
  * Video subdriver
  */
 
+#ifdef CONFIG_THINKPAD_ACPI_VIDEO
+
 enum video_access_mode {
        TPACPI_VIDEO_NONE = 0,
        TPACPI_VIDEO_570,       /* 570 */

@@ -2707,13 +2716,6 @@ static int video_orig_autosw;
 static int video_autosw_get(void);
 static int video_autosw_set(int enable);
 
-TPACPI_HANDLE(vid, root, "\\_SB.PCI.AGP.VGA",  /* 570 */
-          "\\_SB.PCI0.AGP0.VID0",      /* 600e/x, 770x */
-          "\\_SB.PCI0.VID0",   /* 770e */
-          "\\_SB.PCI0.VID",    /* A21e, G4x, R50e, X30, X40 */
-          "\\_SB.PCI0.AGP.VID",        /* all others */
-          );                           /* R30, R31 */
-
 TPACPI_HANDLE(vid2, root, "\\_SB.PCI0.AGPB.VID");      /* G41 */
 
 static int __init video_init(struct ibm_init_struct *iibm)

@@ -3023,6 +3025,8 @@ static struct ibm_struct video_driver_data = {
        .exit = video_exit,
 };
 
+#endif /* CONFIG_THINKPAD_ACPI_VIDEO */
+
 /*************************************************************************
  * Light (thinklight) subdriver
  */

@@ -5807,10 +5811,12 @@ static struct ibm_init_struct ibms_init[] __initdata = {
                .init = wan_init,
                .data = &wan_driver_data,
        },
+#ifdef CONFIG_THINKPAD_ACPI_VIDEO
        {
                .init = video_init,
                .data = &video_driver_data,
        },
+#endif
        {
                .init = light_init,
                .data = &light_driver_data,

It looks like the same patches formatted and set with git 1.5.4.2 made it through to the list.

Quoted 2 lines · Len Brown

It looks like the same patches formatted and set with git 1.5.4.2 made it through to the list.

I suspect 1ca3d6ed01774eab37e96d9c88b840ea618f97af.

Quoted 4 lines · Uwe Kleine-König

Quoted 2 lines · Len Brown

It looks like the same patches formatted and set with git 1.5.4.2 made it through to the list.

I suspect 1ca3d6ed01774eab37e96d9c88b840ea618f97af.

When you talk about commits, please also add the summary line, like this [*1*]:

1ca3d6e (send-email: squelch warning due to comparing undefined $_ to "")

Len said he has the issue with v1.5.4.2-184-gb23b27e but not with v1.5.4.2.

    $ git lg v1.5.4.2..b23b27e -- git-send-email.perl
    1ca3d6e... send-email: squelch warning due to comparing undefined $_ to ""
    6564828... git-send-email: Generalize auto-cc recipient mechanism.
    8a7c56e... git-send-email: Better handling of EOF
    8742997... git-send-email: SIG{TERM,INT} handlers
    2363d74... git-send-email: ssh/login style password requests

and I think you are right. I see In-reply-to: <> in the reject message.

Perhaps we should fix it up like this...

Perhaps we should fix it up like this...

diff --git a/git-send-email.perl b/git-send-email.perl
index ccb87a2..c9f8c6b 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -475,7 +475,7 @@ if ($thread && !defined $initial_reply_to && $prompting) {

        $initial_reply_to = $_;
  }
 -if (defined $initial_reply_to) {
 +if (defined $initial_reply_to && $initial_reply_to ne '') {
        $initial_reply_to =~ s/^\s*<?/</;
        $initial_reply_to =~ s/>?\s*$/>/;

}

Quoted 1 line · Junio C Hamano

Perhaps we should fix it up like this...

Doh, my bad...

Quoted 6 lines

diff --git a/git-send-email.perl b/git-send-email.perl
index ccb87a2..c9f8c6b 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -475,7 +475,7 @@ if ($thread && !defined $initial_reply_to && $prompting) {

Quoted 7 lines

        $initial_reply_to = $_;
  }
 -if (defined $initial_reply_to) {
 +if (defined $initial_reply_to && $initial_reply_to ne '') {
        $initial_reply_to =~ s/^\s*<?/</;
        $initial_reply_to =~ s/>?\s*$/>/;

}

Actually:

if ($initial_reply_to) { ...

should be all that's needed.

And reminds me something ;)
http://kerneltrap.org/mailarchive/git/2007/12/11/488177

The patch looked Ok with my initial cursory review. Success reports with Tested-by: would be appreciated.

I see you took the patch as

0fb7fc7... send-email: fix In-Reply-To regression

. Do you consider adding it to your maint branch?

And reminds me something ;)
http://kerneltrap.org/mailarchive/git/2007/12/11/488177

It looks like the same patches formatted and set with git 1.5.4.2 made it through to the list.

-Len

Quoted 5 lines · Len Brown

git-send-email is getting filtered by vger.kernel.org

git --version
git version 1.5.4.2.184.gb23b