PowerPC 44x: add missing define TARGET_4xx to cuboot-taishan.c
PATCH 1/1 PowerPC 44x: add missing define TARGET_4xx to cuboot-taishan.c
In order to get the proper bd_info structure for PowerPC 440, both TARGET_4xx and TARGET_44x should be defined.
--- arch/powerpc/boot/cuboot-taishan.c | 1 + 1 files changed, 1 insertion(+)
arch/powerpc/boot/cuboot-taishan.c +1 -0
@@ -21,6 +21,7 @@#include "dcr.h" #include "4xx.h" +#define TARGET_4xx#define TARGET_44x#include "ppcboot.h"
Quoted 2 lines · On Thu, 21 Feb 2008 17:43:17 +0300 Valentine Barshak <[email protected]>…
In order to get the proper
bd_infostructure for PowerPC 440, bothTARGET_4xxandTARGET_44xshould be defined.
Could you explain what this adds or why it's needed in the changelog? Also, is this needed for other 440 boards?
josh
Quoted 8 lines · On Sun, 24 Feb 2008 09:32:55 -0600 Josh Boyer <[email protected]>…
Quoted 2 lines · On Thu, 21 Feb 2008 17:43:17 +0300 Valentine Barshak <[email protected]>…
In order to get the proper
bd_infostructure for PowerPC 440, bothTARGET_4xxandTARGET_44xshould be defined.Could you explain what this adds or why it's needed in the changelog? Also, is this needed for other 440 boards?
And actually, looking at this more, does taishan also need TARGET_440GX?
josh
PATCH 1/1 PowerPC 44x: add missing define TARGET_4xx and TARGET_440GX to cuboot-taishan.c
In order to get the proper boad info (bd_info) structure defined in ppcboot.h both TARGET_4xx and TARGET_44x should be defined for all PowerPC 440 boards. The 440GX boards also need TARGET_440GX defined since they have 4 EMACs and there are 4 MAC addesses in bd_info passed by u-boot.
--- arch/powerpc/boot/cuboot-taishan.c | 2 ++ 1 files changed, 2 insertions(+)
arch/powerpc/boot/cuboot-taishan.c +2 -0
@@ -21,7 +21,9 @@#include "dcr.h" #include "4xx.h" +#define TARGET_4xx#define TARGET_44x +#define TARGET_440GX #include "ppcboot.h" static bd_t bd;
Re: [PATCH] PowerPC 44x: add missing define TARGET_4xx and TARGET_440GX to cuboot-taishan.c
Quoted 4 lines · On Tue, 26 Feb 2008 17:58:53 +0300 Valentine Barshak <[email protected]>…
In order to get the proper boad info (
bd_info) structure defined inppcboot.hbothTARGET_4xxandTARGET_44xshould be defined for all PowerPC 440 boards. The 440GX boards also needTARGET_440GXdefined since they have 4 EMACs and there are 4 MAC addesses inbd_infopassed by u-boot.
Thanks, looks much better. I'll send this to Paul later today.
josh