ehci-fsl: add PPC_MPC837x to default y
PATCH 1/1 ehci-fsl: add PPC_MPC837x to default y
Without this patch it's impossible to select ehci-fsl on PPC_MPC837x. Another option would be to convert USB_EHCI_FSL to verbose bool, but I presume EHCI_FSL is purposely made silent.
--- drivers/usb/host/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/usb/host/Kconfig +1 -1
@@ -72,7 +72,7 @@ config USB_EHCI_FSL bool depends on USB_EHCI_HCD select USB_EHCI_ROOT_HUB_TT - default y if MPC834x || PPC_MPC831x + default y if MPC834x || PPC_MPC831x || PPC_MPC837x ---help--- Variation of ARC USB block used in some Freescale chips.
Signature · 1 line
1.5.2.2
Quoted 3 lines · Anton Vorontsov
Without this patch it's impossible to select ehci-fsl on
PPC_MPC837x. Another option would be to convertUSB_EHCI_FSLto verbose bool, but I presumeEHCI_FSLis purposely made silent.
I think making it verbose bool would be better.
-Scott
Quoted 14 lines · Anton Vorontsov
Without this patch it's impossible to select ehci-fsl on
PPC_MPC837x. Another option would be to convertUSB_EHCI_FSLto verbose bool, but I presumeEHCI_FSLis purposely made silent.Signed-off-by Anton Vorontsov <[email protected]>---
drivers/usb/host/Kconfig| 2 +-1 files changed, 1 insertions(+), 1 deletions(-)drivers/usb/host/Kconfig +0
-0
drivers/usb/host/Kconfig config USB_EHCI_FSL · line 75
Quoted 5 lines
drivers/usb/host/Kconfig +1
-1@@ -72,7 +72,7 @@ config USB_EHCI_FSL bool depends on USB_EHCI_HCD select USB_EHCI_ROOT_HUB_TT - default y if MPC834x || PPC_MPC831x + default y if MPC834x || PPC_MPC831x || PPC_MPC837x
Can we just change this to FSL_SOC
- k
Quoted 11 lines · Kumar Gala
Quoted 9 lines · Anton Vorontsov
Without this patch it's impossible to select ehci-fsl on
PPC_MPC837x. Another option would be to convertUSB_EHCI_FSLto verbose bool, but I presumeEHCI_FSLis purposely made silent.Signed-off-by Anton Vorontsov <[email protected]>---
drivers/usb/host/Kconfig| 2 +-1 files changed, 1 insertions(+), 1 deletions(-)
Quoted 12 lines
drivers/usb/host/Kconfig config USB_EHCI_FSL · line 75
Quoted 10 lines
drivers/usb/host/Kconfig +1
-1@@ -72,7 +72,7 @@ config USB_EHCI_FSL bool depends on USB_EHCI_HCD select USB_EHCI_ROOT_HUB_TT - default y if MPC834x || PPC_MPC831x + default y if MPC834x || PPC_MPC831x || PPC_MPC837xCan we just change this to
FSL_SOC
Why do you want to bloat all freescale kernels, even on chips that don't have this hardware?
There are very few cases where default y is justified. This isn't one of them.
-Scott
Quoted 12 lines · Kumar Gala
Quoted 9 lines · Anton Vorontsov
Without this patch it's impossible to select ehci-fsl on
PPC_MPC837x. Another option would be to convertUSB_EHCI_FSLto verbose bool, but I presumeEHCI_FSLis purposely made silent.Signed-off-by Anton Vorontsov <[email protected]>---
drivers/usb/host/Kconfig| 2 +-1 files changed, 1 insertions(+), 1 deletions(-)
Quoted 12 lines
drivers/usb/host/Kconfig config USB_EHCI_FSL · line 75
Quoted 10 lines
drivers/usb/host/Kconfig +1
-1@@ -72,7 +72,7 @@ config USB_EHCI_FSL bool depends on USB_EHCI_HCD select USB_EHCI_ROOT_HUB_TT - default y if MPC834x || PPC_MPC831x + default y if MPC834x || PPC_MPC831x || PPC_MPC837xCan we just change this to
FSL_SOC
Easily. But not "default y"... "depends on" instead, ok? There are plenty of FSL chips without EHCI built-in, so with default y we'll enable it wrongly.
- - - -
From: Anton Vorontsov <[email protected]>
Subject: [USB POWERPC] ehci-fsl: handles other freescale processors
This patch converts USB_EHCI_FSL config option into the verbose bool, so we'll able to select it for other freescale processors with built-in EHCI controller.
--- drivers/usb/host/Kconfig | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)
drivers/usb/host/Kconfig +2 -3
@@ -69,10 +69,9 @@ config USB_EHCI_BIG_ENDIAN_DESC default y config USB_EHCI_FSL - bool - depends on USB_EHCI_HCD + bool "Support for Freescale on-chip EHCI USB controller" + depends on USB_EHCI_HCD && FSL_SOC select USB_EHCI_ROOT_HUB_TT - default y if MPC834x || PPC_MPC831x ---help--- Variation of ARC USB block used in some Freescale chips.
Signature · 1 line
1.5.2.2
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Anton" == Anton Vorontsov <[email protected]> writes:
Hi,
Anton> config USB_EHCI_FSL
Anton> - bool
Anton> - depends on USB_EHCI_HCD
Anton> + bool "Support for Freescale on-chip EHCI USB controller"
Anton> + depends on USB_EHCI_HCD && FSL_SOC
Anton> select USB_EHCI_ROOT_HUB_TT
Anton> - default y if MPC834x || PPC_MPC831x
Notice that I have a patch in the USB queue which fixes up the MPC834x symbol (PPC_MPC834x instead of MPC834x) so this patch won't apply.
Signature · 1 line
Bye, Peter Korsgaard
Quoted 2 lines · Peter Korsgaard
Notice that I have a patch in the USB queue which fixes up the MPC834x symbol (
PPC_MPC834xinstead of MPC834x) so this patch won't apply.
Never mind, Greg fixed it.
Signature · 1 line
Bye, Peter Korsgaard