Skip to contentSkip to conversation

exporting capability name/code pairs (final)

PATCH In review Kohei KaiGai 2 participants 2 messages Feb 22, 2008 Driver core

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 exporting capability name/code pairs (final)

[1/3] Add a private data field within kobj_attribute structure.

This patch add a private data field, declared as void *, within kobj_attribute structure. The _show() and _store() method in the sysfs attribute entries can refer this information to identify what entry is accessed.
It makes easier to share a single method implementation with several similar entries, like ones to export the list of capabilities the running kernel supported.

--

 include/linux/kobject.h |    1 +
 include/linux/sysfs.h   |    7 +++++++
 2 files changed, 8 insertions(+), 0 deletions(-)
include/linux/kobject.h +1 -0
index caa3f41..57d5bf1 100644
@@ -130,6 +130,7 @@ struct kobj_attribute {
 			char *buf);
 	ssize_t (*store)(struct kobject *kobj, struct kobj_attribute *attr,
 			 const char *buf, size_t count);
+	void *data;	/* a private field */
 };
 
 extern struct sysfs_ops kobj_sysfs_ops;
include/linux/sysfs.h +7 -0
index 8027104..6f40ff9 100644
@@ -50,6 +50,13 @@ struct attribute_group {
 	.store	= _store,					\
 }
 
+#define __ATTR_DATA(_name,_mode,_show,_store,_data) {		\
+	.attr = {.name = __stringify(_name), .mode = _mode },   \
+	.show	= _show,					\
+	.store	= _store,					\
+	.data	= (void *)(_data),				\
+}
+	
 #define __ATTR_RO(_name) { \
 	.attr	= { .name = __stringify(_name), .mode = 0444 },	\
 	.show	= _name##_show,					\
Signature · 2 lines
OSS Platform Development Division, NEC
KaiGai Kohei <[email protected]>
#1 lore raw
Quoted 1 line · Kohei KaiGai

[1/3] Add a private data field within kobj_attribute structure.

Your "Subject" did not line up with this description, please change your patch sending format for the next time.

Quoted 8 lines

This patch add a private data field, declared as void *, within kobj_attribute structure. The _show() and _store() method in the sysfs attribute entries can refer this information to identify what entry is accessed.
It makes easier to share a single method implementation with several similar entries, like ones to export the list of capabilities the running kernel supported.

This looks fine, but I'll not take it unless the documentation is updated, as well as the sample code.

thanks,

greg k-h