Skip to contentSkip to conversation

kernel/ns_cgroup.c should #include <linux/nsproxy.h>

PATCH In review Adrian Bunk 2 participants 2 messages Feb 22, 2008 – Feb 23, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel/ns_cgroup.c should #include <linux/nsproxy.h>

Every file should include the headers containing the externs its global functions (in this case for ns_cgroup_clone()).

---
d3446a02068091d59425c51bde1daea777398e44 diff --git a/kernel/ns_cgroup.c b/kernel/ns_cgroup.c index aead4d6..659f321 100644

kernel/ns_cgroup.c +1 -0
@@ -7,6 +7,7 @@
 #include <linux/module.h>
 #include <linux/cgroup.h>
 #include <linux/fs.h>
+#include <linux/nsproxy.h>
 
 struct ns_cgroup {
 	struct cgroup_subsys_state css;
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Adrian Bunk

Every file should include the headers containing the externs its global functions (in this case for ns_cgroup_clone()).

Seems fine... and a good way to ensure that the prototype and definition match.

thanks,
-serge

Quoted 14 lines

---
d3446a02068091d59425c51bde1daea777398e44 diff --git a/kernel/ns_cgroup.c b/kernel/ns_cgroup.c index aead4d6..659f321 100644

kernel/ns_cgroup.c +1 -0
@@ -7,6 +7,7 @@
 #include <linux/module.h>
 #include <linux/cgroup.h>
 #include <linux/fs.h>
+#include <linux/nsproxy.h>
 
 struct ns_cgroup {
 	struct cgroup_subsys_state css;