Skip to contentSkip to conversation

x86: Coding Style fixes to arch/x86/xen/multicalls.c

PATCH In review Paolo Ciarrocchi 3 participants 3 messages Feb 22, 2008 – Feb 23, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 20/20 x86: Coding Style fixes to arch/x86/xen/multicalls.c

File is now error free.
Compile tested.

---
 arch/x86/xen/multicalls.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/x86/xen/multicalls.c +2 -2
index 5e6f36f..5791eb2 100644
@@ -76,7 +76,7 @@ void xen_mc_flush(void)
 		if (ret) {
 			printk(KERN_ERR "%d multicall(s) failed: cpu %d\n",
 			       ret, smp_processor_id());
-			for(i = 0; i < b->mcidx; i++) {
+			for (i = 0; i < b->mcidx; i++) {
 				printk("  call %2d/%d: op=%lu arg=[%lx] result=%ld\n",
 				       i+1, b->mcidx,
 				       b->debug[i].op,
@@ -93,7 +93,7 @@ void xen_mc_flush(void)
 
 	local_irq_restore(flags);
 
-	for(i = 0; i < b->cbidx; i++) {
+	for (i = 0; i < b->cbidx; i++) {
 		struct callback *cb = &b->callbacks[i];
 
 		(*cb->fn)(cb->data);
Signature · 1 line
1.5.4.GIT
#1 lore raw
Quoted 13 lines · Paolo Ciarrocchi

File is now error free.
Compile tested.

---
 arch/x86/xen/multicalls.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/x86/xen/multicalls.c +0 -0
index 5e6f36f..5791eb2 100644

arch/x86/xen/multicalls.c void xen_mc_flush(void) · line 80

Quoted 6 lines
arch/x86/xen/multicalls.c +1 -1
@@ -76,7 +76,7 @@ void xen_mc_flush(void)
 		if (ret) {
 			printk(KERN_ERR "%d multicall(s) failed: cpu %d\n",
 			       ret, smp_processor_id());
-			for(i = 0; i < b->mcidx; i++) {
+			for (i = 0; i < b->mcidx; i++) {
 				printk("  call %2d/%d: op=%lu arg=[%lx] result=%ld\n",

The printk needs a KERN_ERR prefix

#2 lore raw
Quoted 7 lines · Joe Perches

arch/x86/xen/multicalls.c void xen_mc_flush(void) · line 80

Quoted 5 lines
arch/x86/xen/multicalls.c +1 -1
 			printk(KERN_ERR "%d multicall(s) failed: cpu %d\n",
 			       ret, smp_processor_id());
-			for(i = 0; i < b->mcidx; i++) {
+			for (i = 0; i < b->mcidx; i++) {
 				printk("  call %2d/%d: op=%lu arg=[%lx] result=%ld\n",

The printk needs a KERN_ERR prefix

yes - but we prefer to isolate the "does not change the .o in any way" cleanups from cleanups that materially change kernel behavior. (such as printing something else)

Ingo