Skip to contentSkip to conversation

VT notifier fix for VT switch

PATCH Samuel Thibault 2 participants 3 messages Feb 21, 2008 – Feb 23, 2008 Char and misc drivers

lore
Share & tools
lore
#1 lore raw
Quoted 7 lines · On Thu, 21 Feb 2008 21:26:40 +0100 Samuel Thibault…

Notify when VT switch is complete.

drivers/char/vt.c line 708

Quoted 7 lines
drivers/char/vt.c +1 -0
@@ -702,6 +702,7 @@
 	if (is_switch) {
 		set_leds();
 		compute_shiftstate();
+		notify_update(vc);
 	}
 }
 

The changelog is too terse, sorry. What is the reason for making this change? What are the user-visible effects of not having this change? If it fixes a bug, should it be backported to 2.6.24.x and earlier?

etcetera.

#2 lore raw
Quoted 6 lines · Andrew Morton, le Sat 23 Feb 2008 00:04:30 -0800, a écrit :
Quoted 4 lines · On Thu, 21 Feb 2008 21:26:40 +0100 Samuel Thibault…

Notify when VT switch is complete.

Quoted 13 lines

drivers/char/vt.c line 708

Quoted 10 lines
drivers/char/vt.c +1 -0
@@ -702,6 +702,7 @@
 	if (is_switch) {
 		set_leds();
 		compute_shiftstate();
+		notify_update(vc);
 	}
 }
 

The changelog is too terse, sorry. What is the reason for making this change? What are the user-visible effects of not having this change?

Ok:

VT notifier callbacks need to be aware of console switches. This is already partially done from console_callback(), but at that time fg_console, cursor positions, etc. are not yet updated and hence screen readers fetch the old values.

This adds an update notify after all of the values are updated in redraw_screen(vc, 1).

Quoted 1 line

If it fixes a bug, should it be backported to 2.6.24.x and earlier?

It would be useful to backport it to 2.6.24.x indeed. Earlier versions don't have VT notifiers.

Samuel