make c_idle.work have a static address.
PATCH 1/1 make c_idle.work have a static address.
Currently, c_idle is declared in the stack, and thus, have no static address.
Peter Zijlstra points out this simple solution, in which c_idle.work is initializated separatedly. Note that the INIT_WORK macro has a static declaration of a key inside.
Signed-off-by Glauber Costa <[email protected]>
CC Peter Zijlstra <[email protected]>
--- arch/x86/kernel/smpboot_64.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/smpboot_64.c +1 -1
@@ -554,10 +554,10 @@ static int __cpuinit do_boot_cpu(int cpuint timeout;unsigned long start_rip;struct create_idle c_idle = { - .work =__WORK_INITIALIZER (c_idle.work, do_fork_idle), .cpu = cpu, .done =COMPLETION_INITIALIZER_ONSTACK (c_idle.done), }; +INIT_WORK (&c_idle.work, do_fork_idle);/* allocate memory for gdts of secondary cpus. Hotplug is considered */ if (!cpu_gdt_descr[cpu].address &&
Signature · 1 line
1.4.2
Ingo Molnar
AppliedQuoted 6 lines · Glauber Costa
Currently,
c_idleis declared in the stack, and thus, have no static address.Peter Zijlstra points out this simple solution, in which c_idle.work is initializated separatedly. Note that the
INIT_WORKmacro has a static declaration of a key inside.
thanks, applied.
Ingo