x86: fix build on non-C locales.
PATCH 1/1 x86: fix build on non-C locales.
x86: fix build on some non-C locales[1].
For some locales regex range [a-zA-Z] does not work as it is supposed to so we have to specify LANG=C to make it work as intended.
[1] http://en.wikipedia.org/wiki/Estonian_alphabet
arch/x86/vdso/Makefile +2 -1
@@ -50,7 +50,8 @@ obj-$(VDSO64-y) += vdso-syms.lds sed-vdsosym := -e 's/^00*/0/' \ -e 's/^\([0-9a-fA-F]*\) . \(VDSO[a-zA-Z0-9_]*\)$$/\2 = 0x\1;/p' quiet_cmd_vdsosym = VDSOSYM $@ - cmd_vdsosym = $(NM) $< | sed -n $(sed-vdsosym) | LC_ALL=C sort > $@ + cmd_vdsosym = $(NM) $< | LC_ALL=C sed -n $(sed-vdsosym) \ + | LC_ALL=C sort > $@ $(obj)/%-syms.lds: $(obj)/%.so.dbg FORCE $(call if_changed,vdsosym)
Ingo Molnar
AppliedQuoted 4 lines · Priit Laes
x86: fix build on some non-C locales[1].
For some locales regex range [a-zA-Z] does not work as it is supposed to so we have to specify LANG=C to make it work as intended.
thanks, applied.
Ingo
Hi Prit.
Could we just use [[:alnum:]] and drop the setting of LC_ALL?
Sam
Ühel kenal päeval, P, 2008-02-24 kell 10:03, kirjutas Sam Ravnborg:
Quoted 3 lines
Hi Prit.
Could we just use [[:alnum:]] and drop the setting of
LC_ALL?
Yes, it works. Reverted the previous patch and did this:
arch/x86/vdso/Makefile +0 -0
@@ -48,7 +48,7 @@ obj-$(VDSO64-y) += vdso-syms.lds # Match symbols in the DSO that look like VDSO*; produce a file of
constants.
#
sed-vdsosym := -e 's/^00*/0/' \
- -e 's/^\([0-9a-fA-F]*\) . \(VDSO[a-zA-Z0-9_]*\)$$/\2 = 0x\1;/p'
+ -e 's/^\([[:xdigit:]]*\) . \(VDSO[[:alnum:]_]*\)$$/\2 = 0x\1;/p'
quiet_cmd_vdsosym = VDSOSYM $@
cmd_vdsosym = $(NM) $< | sed -n $(sed-vdsosym) | LC_ALL=C sort >
$@
Review
Quoted 3 lines · Priit Laes
sed-vdsosym := -e 's/^00*/0/' \
(quoted diff) +1
-1- -e 's/^\([0-9a-fA-F]*\) . \(VDSO[a-zA-Z0-9_]*\)$$/\2 = 0x\1;/p' + -e 's/^\([[:xdigit:]]*\) . \(VDSO[[:alnum:]_]*\)$$/\2 = 0x\1;/p'
thanks, i picked up this one instead of the first version.
Ingo