Skip to contentSkip to conversation

IDE: new series of Coding Style Fixes

PATCH In review Paolo Ciarrocchi 2 participants 4 messages Feb 23, 2008 – Feb 26, 2008 libata

lore
Share & tools
lore
#0 lore raw

cover IDE: new series of Coding Style Fixes

Bart,
here is a new series of patches that remove some errors and warnings reported by checkpatch.pl from the IDE subsystem.

All the patches have been compile tested and are against this morning (CET time :-) linux-next

Paolo Ciarrocchi (6):
IDE: Coding Style fixes to drivers/ide/pci/opti621.c
IDE: Coding Style fixes to drivers/ide/legacy/hd.c
IDE: Coding Style fixes to drivers/ide/legacy/ali14xx.c
IDE: Coding Style fixes to drivers/ide/pci/it8213.c
IDE: Coding Style fixes to drivers/ide/ide-floppy.c
IDE: Coding Style fixes to drivers/ide/pci/cmd640.c

 drivers/ide/ide-floppy.c     |    4 +-
 drivers/ide/legacy/ali14xx.c |   11 +++--
 drivers/ide/legacy/hd.c      |   79 ++++++++++++++++++------------------
 drivers/ide/pci/cmd640.c     |   90 +++++++++++++++++++++---------------------
 drivers/ide/pci/it8213.c     |    9 ++--
 drivers/ide/pci/opti621.c    |   50 ++++++++++++------------
 6 files changed, 122 insertions(+), 121 deletions(-)

Ciao,
Paolo

#1 lore raw
Quoted 4 lines · Paolo Ciarrocchi

Bart,
here is a new series of patches that remove some errors and warnings reported by checkpatch.pl from the IDE subsystem.

Quoted 8 lines

All the patches have been compile tested and are against this morning (CET time :-) linux-next

Paolo Ciarrocchi (6):
IDE: Coding Style fixes to drivers/ide/pci/opti621.c
IDE: Coding Style fixes to drivers/ide/legacy/hd.c
IDE: Coding Style fixes to drivers/ide/legacy/ali14xx.c
IDE: Coding Style fixes to drivers/ide/pci/it8213.c

the above change (patch 4/6) seems to be m.i.a. ?

Quoted 10 lines

IDE: Coding Style fixes to drivers/ide/ide-floppy.c
IDE: Coding Style fixes to drivers/ide/pci/cmd640.c

 drivers/ide/ide-floppy.c     |    4 +-
 drivers/ide/legacy/ali14xx.c |   11 +++--
 drivers/ide/legacy/hd.c      |   79 ++++++++++++++++++------------------
 drivers/ide/pci/cmd640.c     |   90 +++++++++++++++++++++---------------------
 drivers/ide/pci/it8213.c     |    9 ++--
 drivers/ide/pci/opti621.c    |   50 ++++++++++++------------
 6 files changed, 122 insertions(+), 121 deletions(-)

I applied all the rest (some with minor fixes).

Thanks,
Bart

#2 lore raw
Quoted 9 lines · Bartlomiej Zolnierkiewicz
Quoted 7 lines · Paolo Ciarrocchi

Bart,
here is a new series of patches that remove some errors and warnings reported by checkpatch.pl from the IDE subsystem.

All the patches have been compile tested and are against this morning (CET time :-) linux-next

Quoted 7 lines
Quoted 5 lines

Paolo Ciarrocchi (6):
IDE: Coding Style fixes to drivers/ide/pci/opti621.c
IDE: Coding Style fixes to drivers/ide/legacy/hd.c
IDE: Coding Style fixes to drivers/ide/legacy/ali14xx.c
IDE: Coding Style fixes to drivers/ide/pci/it8213.c

the above change (patch 4/6) seems to be m.i.a. ?

Yes, sorry about that. I must have forgot to manually send out the patch. I'll do that as soon as I access again to the linux box.

I really wish to be able to use git-send-mail with gmail, unfortunatelly it's still not working
even applying all the suggestions I've got from other gmail/git users.

Quoted 11 lines
Quoted 10 lines

IDE: Coding Style fixes to drivers/ide/ide-floppy.c
IDE: Coding Style fixes to drivers/ide/pci/cmd640.c

 drivers/ide/ide-floppy.c     |    4 +-
 drivers/ide/legacy/ali14xx.c |   11 +++--
 drivers/ide/legacy/hd.c      |   79 ++++++++++++++++++------------------
 drivers/ide/pci/cmd640.c     |   90 +++++++++++++++++++++---------------------
 drivers/ide/pci/it8213.c     |    9 ++--
 drivers/ide/pci/opti621.c    |   50 ++++++++++++------------
 6 files changed, 122 insertions(+), 121 deletions(-)
Quoted 1 line

I applied all the rest (some with minor fixes).

Good. Where can I look to see the end result of our work?

Ciao,

Signature · 2 lines
Paolo
http://paolo.ciarrocchi.googlepages.com/
#3 lore raw

On Sunday 24 February 2008, Paolo Ciarrocchi wrote:

[...]

Quoted 11 lines
Quoted 9 lines
Quoted 7 lines
 drivers/ide/ide-floppy.c     |    4 +-
 drivers/ide/legacy/ali14xx.c |   11 +++--
 drivers/ide/legacy/hd.c      |   79 ++++++++++++++++++------------------
 drivers/ide/pci/cmd640.c     |   90 +++++++++++++++++++++---------------------
 drivers/ide/pci/it8213.c     |    9 ++--
 drivers/ide/pci/opti621.c    |   50 ++++++++++++------------
 6 files changed, 122 insertions(+), 121 deletions(-)

I applied all the rest (some with minor fixes).

Good. Where can I look to see the end result of our work?

the "usual" place:

http://www.kernel.org/pub/linux/kernel/people/bart/pata-2.6/

[ or "tomorrow's" linux-next ]

Thanks,
Bart