Skip to contentSkip to conversation

IPv4: Reset scope when changing address

PATCH RESEND In review Bjørn Mork 2 participants 4 messages Feb 16, 2008 – Feb 27, 2008

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 IPv4: Reset scope when changing address

<#part type=text/plain nofile=yes>
Any comments on this? Apparently introduced in 2.1.68, so there's not much hurry. But I'd still like to hear whether that analysis is correct or not...
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="==-=-="

The bug did bite at least one user, who did have to resort to rebooting the system after an "ifconfig eth0 127.0.0.1" typo.

Deleting the address and adding a new is a less intrusive workaround. But I still beleive this is a bug that should be fixed. Some way or another.

Another possibility would be to remove the scope mangling based on address. This will always be incomplete (are 127/8 the only address space with host scope requirements?)

Bj�ørn

<#part type=text/x-diff filename="devinet-rt_scope-fix.patch" disposition=inline nofile=yes> We set the scope to RT_SCOPE_HOST if an IPv4 interface is configured
with a loopback address (127/8). The scope is never reset, and will
remain set to RT_SCOPE_HOST after changing the address. This patch
resets the scope if the address is changed again, to restore normal functionality.

--==-=-=

 devinet.c |    1 +
 1 file changed, 1 insertion(+)
net/ipv4/devinet.c +1 -0
@@ -753,6 +753,7 @@
 			inet_del_ifa(in_dev, ifap, 0);
 			ifa->ifa_broadcast = 0;
 			ifa->ifa_anycast = 0;
+			ifa->ifa_scope = 0;
 		}
 
 		ifa->ifa_address = ifa->ifa_local = sin->sin_addr.s_addr;

--==-=-=
Content-Type: text/plain; charset=iso-8859-1

--==-=-=--

maintainer
#1 lore raw

From: Bjørn_Mork <[email protected]>
Date: Sat, 16 Feb 2008 12:45:31 +0100

Quoted 6 lines

<#part type=text/plain nofile=yes>
Any comments on this? Apparently introduced in 2.1.68, so there's not much hurry. But I'd still like to hear whether that analysis is correct or not...
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="==-=-="

Please clear up all of the inline mime tag stuff in your outgoing emails. Your description and patch is very difficult to read because of this.

Thank you.

#2 lore raw
Quoted 3 lines · David Miller

Please clear up all of the inline mime tag stuff in your outgoing emails. Your description and patch is very difficult to read because of this.

Ouch, sorry. I wish I could blame my user agent, but this was mostly my sausage fingers..

New attempt:

This bug did bite at least one user, who did have to resort to rebooting the system after an "ifconfig eth0 127.0.0.1" typo.

Deleting the address and adding a new is a less intrusive workaround. But I still beleive this is a bug that should be fixed. Some way or another.

Another possibility would be to remove the scope mangling based on address. This will always be incomplete (are 127/8 the only address space with host scope requirements?)

We set the scope to RT_SCOPE_HOST if an IPv4 interface is configured with a loopback address (127/8). The scope is never reset, and will remain set to RT_SCOPE_HOST after changing the address. This patch resets the scope if the address is changed again, to restore normal functionality.

---
 devinet.c |    1 +
 1 file changed, 1 insertion(+)
net/ipv4/devinet.c +1 -0
@@ -753,6 +753,7 @@
 			inet_del_ifa(in_dev, ifap, 0);
 			ifa->ifa_broadcast = 0;
 			ifa->ifa_anycast = 0;
+			ifa->ifa_scope = 0;
 		}
 
 		ifa->ifa_address = ifa->ifa_local = sin->sin_addr.s_addr;
maintainer
#3 lore raw

From: Bjørn_Mork <[email protected]>
Date: Sun, 24 Feb 2008 19:12:38 +0100

Quoted 7 lines

We set the scope to RT_SCOPE_HOST if an IPv4 interface is configured with a loopback address (127/8). The scope is never reset, and will remain set to RT_SCOPE_HOST after changing the address. This patch resets the scope if the address is changed again, to restore normal functionality.

This patch looks fine, applied, thanks!