Advansys regression between 2.6.23.8 and 2.6.24.2
Hi,
I just upgraded my system from 2.6.23.8 to 2.6.24.2, and when loading the advansys module, it paniced, with "Kernel BUG at advansys.c:6335". The issue is that the overrun buffer is not aligned on 8 bytes.
The patch 7d5d408c77cee95d1380511de46b7a4c8dc2211d [1], by FUJITA Tomonori, which has been committed a few days ago, fixes the issue. The commit log says that the structure should be 8-byte aligned on 2.6.23 and 2.6.24, but it doesn't seem to be the case in 2.6.24. I have not identified which commit broke the driver, but I confirm that Tomonori's patch fixes the problem.
I've added Greg and Chris as Cc: because such a patch should probably be included in the next -stable of 2.6.24, but of course Tomonori and Matthew are best placed to say what should be done.
Thanks,
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Free Embedded Linux Training Materials on http://free-electrons.com/training (More than 1500 pages!)
Quoted 2 lines · Thomas Petazzoni
I have not identified which commit broke the driver, but I confirm that Tomonori's patch fixes the problem.
I suspect that the issue has been introduced by d10fb2c7b5ce1b475df50cde9262d2c3fe3d296e, added in 2.6.24 by Matthew.
Sincerly,
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Free Embedded Linux Training Materials on http://free-electrons.com/training (More than 1500 pages!)
James Bottomley
maintainerQuoted 11 lines · Thomas Petazzoni
I just upgraded my system from 2.6.23.8 to 2.6.24.2, and when loading the advansys module, it paniced, with "Kernel BUG at advansys.c:6335". The issue is that the overrun buffer is not aligned on 8 bytes.
The patch
7d5d408c77cee95d1380511de46b7a4c8dc2211d[1], by FUJITA Tomonori, which has been committed a few days ago, fixes the issue. The commit log says that the structure should be 8-byte aligned on 2.6.23 and 2.6.24, but it doesn't seem to be the case in 2.6.24. I have not identified which commit broke the driver, but I confirm that Tomonori's patch fixes the problem.
Quoted 3 lines
I've added Greg and Chris as Cc: because such a patch should probably be included in the next -stable of 2.6.24, but of course Tomonori and Matthew are best placed to say what should be done.
Yes, it's already on its way to stable. The process requires the fix to be committed upstream first. There's an automated script that sends these commits back to stable once they're upstream (provided they're tagged correctly).
James
Hi James,
Quoted 4 lines · James Bottomley
Yes, it's already on its way to stable. The process requires the fix to be committed upstream first. There's an automated script that sends these commits back to stable once they're upstream (provided they're tagged correctly).
I might be wrong, but I don't see this patch in 2.6.24.3, which has just been released.
Sincerly,
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Free Embedded Linux Training Materials on http://free-electrons.com/training (More than 1500 pages!)