Optimise tick_nohz_stop_sched_tick() a bit
PATCH 1/1 Optimise tick_nohz_stop_sched_tick() a bit
Call
ts = &per_cpu(tick_cpu_sched, cpu); and cpu = smp_processor_id();
once instead of twice.
No functional change done, as changed code runs with local irq off. Reduces source lines and text size (20bytes on x86_64).
Signed-off-by Karsten Wiese <[email protected]>
--- kernel/time/tick-sched.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-)
kernel/time/tick-sched.c +2 -4
@@ -158,9 +158,8 @@ void tick_nohz_stop_idle(int cpu) } } -static ktime_t tick_nohz_start_idle (int cpu) +static ktime_t tick_nohz_start_idle (int cpu,struct tick_sched *ts) { -struct tick_sched *ts = &per_cpu (tick_cpu_sched, cpu);ktime_t now, delta; now =ktime_get ();
@@ -201,8 +200,8 @@ void tick_nohz_stop_sched_tick(void)local_irq_save (flags); cpu =smp_processor_id (); - now =tick_nohz_start_idle (cpu); ts = &per_cpu (tick_cpu_sched, cpu); + now =tick_nohz_start_idle (cpu, ts);/* * If this cpu is offline and it is the one which updates
@@ -222,7 +221,6 @@ void tick_nohz_stop_sched_tick(void)if (need_resched ()) goto end; - cpu =smp_processor_id ();if (unlikely (local_softirq_pending ())) {static int ratelimit;
Signature · 1 line
1.5.3.3
Quoted 20 lines · On Thu, 28 Feb 2008 15:10:50 +0100 Karsten Wiese <[email protected]>…
Call
ts = &per_cpu(tick_cpu_sched, cpu); and cpu = smp_processor_id();once instead of twice.
No functional change done, as changed code runs with local irq off. Reduces source lines and text size (20bytes on
x86_64).Signed-off-by Karsten Wiese <[email protected]>--- kernel/time/tick-sched.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-)kernel/time/tick-sched.c +0
-0
kernel/time/tick-sched.c void tick_nohz_stop_idle(int cpu) · line 161
Quoted 5 lines
kernel/time/tick-sched.c +1
-1@@ -158,9 +158,8 @@ void tick_nohz_stop_idle(int cpu) } } -static ktime_t tick_nohz_start_idle (int cpu) +static ktime_t tick_nohz_start_idle (int cpu,struct tick_sched *ts)
Argument `cpu' is now unused.
Quoted 16 lines
kernel/time/tick-sched.c +1
-2{ -struct tick_sched *ts = &per_cpu (tick_cpu_sched, cpu);ktime_t now, delta; now =ktime_get ();@@ -201,8 +200,8 @@ void tick_nohz_stop_sched_tick(void)local_irq_save (flags); cpu =smp_processor_id (); - now =tick_nohz_start_idle (cpu); ts = &per_cpu (tick_cpu_sched, cpu); + now =tick_nohz_start_idle (cpu, ts);/* * If this cpu is offline and it is the one which updates
kernel/time/tick-sched.c void tick_nohz_stop_sched_tick(void) · line 226
Quoted 7 lines
kernel/time/tick-sched.c +0
-1@@ -222,7 +221,6 @@ void tick_nohz_stop_sched_tick(void)if (need_resched ()) goto end; - cpu =smp_processor_id ();if (unlikely (local_softirq_pending ())) {static int ratelimit;
kernel/time/tick-sched.c renamed from kernel/time/tick-sched.c~optimise-tick_nohz_stop_sched_tick-a-bit-fix +2 -2
@@ -158,7 +158,7 @@ void tick_nohz_stop_idle(int cpu) } } -static ktime_t tick_nohz_start_idle (int cpu,struct tick_sched *ts) +static ktime_t tick_nohz_start_idle (struct tick_sched *ts) {ktime_t now, delta;
@@ -200,7 +200,7 @@ void tick_nohz_stop_sched_tick(void) cpu =smp_processor_id (); ts = &per_cpu (tick_cpu_sched, cpu); - now =tick_nohz_start_idle (cpu, ts); + now =tick_nohz_start_idle (ts);/* * If this cpu is offline and it is the one which updates
_
Quoted 7 lines · Andrew Morton
On Thu, 28 Feb 2008 15:10:50 +0100 Karsten Wiese <[email protected]> wrote:
kernel/time/tick-sched.c renamed from kernel/time/tick-sched.c~optimise-tick_nohz_stop_sched_tick-a-bit-fix +1
-1-static ktime_t tick_nohz_start_idle (int cpu,struct tick_sched *ts) +static ktime_t tick_nohz_start_idle (struct tick_sched *ts) {ktime_t now, delta;
kernel/time/tick-sched.c void tick_nohz_stop_sched_tick(void) · line 206
Quoted 8 lines
kernel/time/tick-sched.c renamed from kernel/time/tick-sched.c~optimise-tick_nohz_stop_sched_tick-a-bit-fix +1
-1@@ -200,7 +200,7 @@ void tick_nohz_stop_sched_tick(void) cpu =smp_processor_id (); ts = &per_cpu (tick_cpu_sched, cpu); - now =tick_nohz_start_idle (cpu, ts); + now =tick_nohz_start_idle (ts);/* * If this cpu is offline and it is the one which updates
Combined patch applied to hrt.git
Thanks,
tglx