Skip to contentSkip to conversation

Device core: Remove dpm_sysfs_remove() from error path of device_add()

PATCH New Rafael J. Wysocki 1 participant 1 message Mar 3, 2008 Driver core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Device core: Remove dpm_sysfs_remove() from error path of device_add()

Hi Greg,

The appended patch fixes a bug in the error path of device_add().

Please accept it for 2.6.25.

Thanks,
Rafael

---
From: Rafael J. Wysocki <[email protected]>

Since device_pm_remove(dev) calls dpm_sysfs_remove(dev), it's incorrect to call the latter after the former in the device_add() error path.

---
 drivers/base/core.c |    1 -
 1 file changed, 1 deletion(-)
drivers/base/core.c +0 -1
Index: linux-2.6/drivers/base/core.c
===================================================================
@@ -839,7 +839,6 @@ int device_add(struct device *dev)
 	return error;
  BusError:
 	device_pm_remove(dev);
-	dpm_sysfs_remove(dev);
  PMError:
 	if (dev->bus)
 		blocking_notifier_call_chain(&dev->bus->p->bus_notifier,