Skip to contentSkip to conversation

fix taihu soft spi_read

PATCH New Markus Brunner 2 participants 2 messages Mar 5, 2008 – Mar 7, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix taihu soft spi_read

The taihu board used gpio_read_out_bit which reads the output register and not the pin state.

---

The function gpio_read_out_bit didn't exist in u-boot <= 1.3.1 so every usage of gpio_read_out_bit deserves a closer look.

board/amcc/taihu/taihu.c +1 -1
index ea83671..eedde59 100644
@@ -162,7 +162,7 @@ void spi_sda(int bit)
 
 unsigned char spi_read(void)
 {
-       return (unsigned char)gpio_read_out_bit(SPI_DIN_GPIO15);
+       return (unsigned char)gpio_read_in_bit(SPI_DIN_GPIO15);
 }
 
 void taihu_spi_chipsel(int cs)
#1 lore raw

PATCH 1/1 fix taihu soft spi_read

Quoted 2 lines · Markus Brunner

The taihu board used gpio_read_out_bit which reads the output register and not the pin state.

Applied to u-boot-ppc4xx custodian repository. Will get pulled into 1.3.2 release. Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================