Skip to contentSkip to conversation

send_sigqueue: don't take rcu lock

PATCH In review Oleg Nesterov 1 participant 1 message Mar 5, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 send_sigqueue: don't take rcu lock

(depends on lock_task_sighand-add-rcu-lock-unlock.patch)

lock_task_sighand() was changed, send_sigqueue() doesn't need rcu_read_lock() any longer.

kernel/signal.c renamed from kernel/signal.c~1_SS_NO_RCU +0 -4
@@ -1311,8 +1311,6 @@ int send_sigqueue(int sig, struct sigque
 	 * We return -1, when the task is marked exiting, so
 	 * posix_timer_event can redirect it to the group leader
 	 */
-	rcu_read_lock();
-
 	if (!likely(lock_task_sighand(p, &flags)))
 		goto out_err;
 
@@ -1323,8 +1321,6 @@ int send_sigqueue(int sig, struct sigque
 
 	unlock_task_sighand(p, &flags);
 out_err:
-	rcu_read_unlock();
-
 	return ret;
 }