Skip to contentSkip to conversation

signals: handle_stop_signal: don't worry about SIGKILL

PATCH Oleg Nesterov 2 participants 2 messages Mar 9, 2008 – Mar 11, 2008

lore
Share & tools
lore
#0 lore raw

handle_stop_signal() clears SIGNAL_STOP_DEQUEUED when sig == SIGKILL. Remove this nasty special case. It was needed to prevent the race with group stop and exit caused by thread-specific SIGKILL. Now that we use complete_signal() for private signals too this is not needed, complete_signal() will notice SIGKILL and abort the soon-to-begin group stop.

Except: the target thread is dead (has PF_EXITING). But in that case we should not just clear SIGNAL_STOP_DEQUEUED and nothing more. We should either kill the whole thread group, or silently ignore the signal.

I suspect we are not right wrt zombie leaders, but this is another issue which and should be fixed separately. Note that this check can't abort the group stop if it was already started/finished, this check only adds a subtle side effect if we race with the thread which has already dequeued sig_kernel_stop() signal and temporary released ->siglock.

kernel/signal.c renamed from kernel/signal.c~7_HSS_NO_KILL +0 -6
@@ -643,12 +643,6 @@ static void handle_stop_signal(int sig, 
 			 */
 			signal->flags &= ~SIGNAL_STOP_DEQUEUED;
 		}
-	} else if (sig == SIGKILL) {
-		/*
-		 * Make sure that any pending stop signal already dequeued
-		 * is undone by the wakeup for SIGKILL.
-		 */
-		signal->flags &= ~SIGNAL_STOP_DEQUEUED;
 	}
 }
 
#1 lore raw

This look OK to me too. I'm not 100% sure we didn't overlook some subtlety. But I think your analysis is sound.

Thanks,
Roland