Skip to contentSkip to conversation

dasd: fix double elevator_exit call when deadline

PATCH Josef 'Jeff' Sipek 1 participant 1 message Mar 10, 2008 1 message not in the archive s390

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 1204884215.21438.3.camel@localhost

#1 lore raw
Quoted 26 lines · Martin Schwidefsky
Quoted 15 lines · Heiko Carstens
Quoted 10 lines · Martin Schwidefsky
Quoted 7 lines · Bastian Blank

Review

Quoted 4 lines · Josef 'Jeff' Sipek

config DASD

(quoted diff) +1 -1
 	tristate "Support for DASD devices"
-	depends on CCW && BLOCK
+	depends on CCW && IOSCHED_DEADLINE && BLOCK

select IOSCHED_DEADLINE?

Yes, this makes more sense.

Err... I made the "depends on" suggestion because of this from Documentation/kbuild/kconfig-language.txt :

Quoted 9 lines

Note:
select is evil.... select will by brute force set a symbol equal to 'y' without visiting the dependencies. So abusing select you are able to select a symbol FOO even if FOO depends on BAR that is not set. In general use select only for non-visible symbols (no promts anywhere) and for symbols with no dependencies. That will limit the usefulness but on the other hand avoid the illegal configurations all over. kconfig should one day warn about such things.

Quoted 3 lines

IOSCHED_DEADLINE depends only on BLOCK. Since the dasd driver itself depends on BLOCK the select will always work. I think this is better than a hidden dasd driver if IOSCHED_DEADLINE is not selected.

It gets more ugly if/when someone changes the IOSCHED_DEADLINE dependencies => changes are that the DASD 'select' statement will not be updated.

Josef 'Jeff' Sipek.

Signature · 3 lines
Mankind invented the atomic bomb, but no mouse would ever construct a
mousetrap.
		- Albert Einstein