Skip to contentSkip to conversation

sensord: Define min value for loadavg in rrd

PATCH In review Aurelien Jarno 2 participants 2 messages Mar 2, 2008 – Mar 11, 2008

lore
Share & tools
lore

Aurelien Jarno

author
#0 lore raw

PATCH 1/1 sensord: Define min value for loadavg in rrd

The patch below changes sensord so that it sets the minimum value of the loadavg field to 0 in the rrd file, as this value can't be negative.

Index: prog/sensord/sensord.h
=================================--- prog/sensord/sensord.h (révision 5132)
+++ prog/sensord/sensord.h (copie de travail)
@@ -79,6 +79,7 @@
DataType_voltage = 0,
DataType_rpm,
DataType_temperature,
+ DataType_loadavg,
DataType_other = -1
} DataType;

Index: prog/sensord/rrd.c
=================================--- prog/sensord/rrd.c (révision 5132)
+++ prog/sensord/rrd.c (copie de travail)
@@ -202,6 +202,10 @@

         min = "0";
         max = "250";
         break;
+      case DataType_loadavg:
+        min = "0";
+        max = "U";
+        break;
       default:
         min = max = "U";
         break;

@@ -217,8 +221,11 @@
int ret = 0;
struct ds data = { 0, argv};
ret = applyToFeatures (rrdGetSensors_DS, &data);
- if (!ret && doLoad)
- ret = rrdGetSensors_DS (&data, LOADAVG, LOAD_AVERAGE, NULL);
+ if (!ret && doLoad) {

+    FeatureDescriptor feature;
+    feature.type = DataType_loadavg;
+    ret = rrdGetSensors_DS (&data, LOADAVG, LOAD_AVERAGE, &feature);

+ }
return ret ? -1 : data.num;
}

Signature · 9 lines
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   [email protected]         | [email protected]
   `-    people.debian.org/~aurel32 | www.aurel32.net

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#1 lore raw

Re: [lm-sensors] [PATCH] sensord: Define min value for loadavg in

Hi Aurelien,

Quoted 33 lines · Aurelien Jarno

The patch below changes sensord so that it sets the minimum value of the loadavg field to 0 in the rrd file, as this value can't be negative.

Index: prog/sensord/sensord.h
=================================> --- prog/sensord/sensord.h (révision 5132)
+++ prog/sensord/sensord.h (copie de travail)

(quoted diff) +1 -0
@@ -79,6 +79,7 @@
   DataType_voltage = 0,
   DataType_rpm,
   DataType_temperature,
+  DataType_loadavg,
   DataType_other = -1
 } DataType;

Index: prog/sensord/rrd.c
=================================> --- prog/sensord/rrd.c (révision 5132)
+++ prog/sensord/rrd.c (copie de travail)

(quoted diff) +4 -0
@@ -202,6 +202,10 @@
         min = "0";
         max = "250";
         break;
+      case DataType_loadavg:
+        min = "0";
+        max = "U";
+        break;
       default:
         min = max = "U";
         break;

@@ -217,8 +221,11 @@
   int ret = 0;
   struct ds data = { 0, argv};
   ret = applyToFeatures (rrdGetSensors_DS, &data);

Review line 231

Quoted 10 lines
(quoted diff) +5 -2
-  if (!ret && doLoad)
-    ret = rrdGetSensors_DS (&data, LOADAVG, LOAD_AVERAGE, NULL);
+  if (!ret && doLoad) {
+    FeatureDescriptor feature;
+    feature.type = DataType_loadavg;
+    ret = rrdGetSensors_DS (&data, LOADAVG, LOAD_AVERAGE, &feature);
+  }
   return ret ? -1 : data.num;
 }

What does this change in practice? What's the benefit?

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors