scheduler fixes
Linus, please pull the latest scheduler fixes git tree from:
git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched-devel.git for-linus
Thanks,
Ingo
------------------>
Gregory Haskins (2):
Revert "cpu hotplug: adjust root-domain->online span in response to hotplug event"
keep rd->online and cpu_online_map in synckernel/sched.c | 21 +++++++++++++-------- 1 files changed, 13 insertions(+), 8 deletions(-)
kernel/sched.c +13 -8
@@ -5813,13 +5813,6 @@ migration_call(struct notifier_block *nfb, unsigned long action, void *hcpu)/* Must be high prio: stop_machine expects to yield to it. */ rq =task_rq_lock (p, &flags);__setscheduler (rq, p,SCHED_FIFO ,MAX_RT_PRIO -1 ); - -/* Update our root-domain */ -if (rq->rd) { -BUG_ON (!cpu_isset (cpu, rq->rd->span)); -cpu_set (cpu, rq->rd->online); - } -task_rq_unlock (rq, &flags);cpu_rq (cpu)->migration_thread = p;break ;
@@ -5828,6 +5821,15 @@ migration_call(struct notifier_block *nfb, unsigned long action, void *hcpu)case CPU_ONLINE_FROZEN :/* Strictly unnecessary, as first user will wake it. */ wake_up_process (cpu_rq (cpu)->migration_thread); + +/* Update our root-domain */ + rq =cpu_rq (cpu); +spin_lock_irqsave (&rq->lock, flags); +if (rq->rd) { +BUG_ON (!cpu_isset (cpu, rq->rd->span)); +cpu_set (cpu, rq->rd->online); + } +spin_unlock_irqrestore (&rq->lock, flags);break ;#ifdef CONFIG_HOTPLUG_CPU
@@ -5879,7 +5881,8 @@ migration_call(struct notifier_block *nfb, unsigned long action, void *hcpu)spin_unlock_irq (&rq->lock);break ; -case CPU_DOWN_PREPARE : +case CPU_DYING : +case CPU_DYING_FROZEN :/* Update our root-domain */ rq =cpu_rq (cpu);spin_lock_irqsave (&rq->lock, flags);
@@ -6103,6 +6106,8 @@ static void rq_attach_root(struct rq *rq, struct root_domain *rd) rq->rd = rd;cpu_set (rq->cpu, rd->span); +if (cpu_isset (rq->cpu, cpu_online_map)) +cpu_set (rq->cpu, rd->online);for (class = sched_class_highest; class; class = class->next) {if (class->join_domain)
Quoted 5 lines · Ingo Molnar
Linus, please pull the latest scheduler fixes git tree from:
git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched-devel.gitfor-linus
Quoted 8 lines
Thanks,
Ingo
------------------>
Gregory Haskins (2):Revert "cpu hotplug: adjust root-domain->online span in response to hotplug event" keep rd->online and cpu_online_map in sync
Does it fix the poweroff problem reported by Andrew?
Rafael
Quoted 8 lines · On Tue, 11 Mar 2008 23:30:58 +0100 "Rafael J. Wysocki" <[email protected]> wrote:
Quoted 7 lines · Ingo Molnar
Linus, please pull the latest scheduler fixes git tree from:
git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched-devel.gitfor-linusThanks,
Quoted 9 lines
Quoted 6 lines
Ingo
------------------>
Gregory Haskins (2):Revert "cpu hotplug: adjust root-domain->online span in response to hotplug event" keep rd->online and cpu_online_map in syncDoes it fix the poweroff problem reported by Andrew?
Yes, this regression is fixed in current mainline.