Skip to contentSkip to conversation

sh: Add support PCI host driver for SH7751/SH7751R

PATCH New Nobuhiro Iwamatsu 2 participants 3 messages Mar 12, 2008 – Mar 23, 2008

lore
Share & tools
lore

Nobuhiro Iwamatsu

author
#0 lore raw

PATCH 1/1 sh: Add support PCI host driver for SH7751/SH7751R

Signed-off-by Nobuhiro Iwamatsu <[email protected]>
---
 cpu/sh4/Makefile     |    2 +-
 cpu/sh4/pci-sh7751.c |  204 ++++++++++++++++++++++++++++++++++++++++++++++++++
 include/asm-sh/pci.h |    4 +-
 3 files changed, 208 insertions(+), 2 deletions(-)
 create mode 100644 cpu/sh4/pci-sh7751.c
cpu/sh4/Makefile +1 -1
index 7a53cb6..6dc8a59 100644
@@ -30,7 +30,7 @@ LIB	= $(obj)lib$(CPU).a
 
 START	= start.o
 OBJS	= cpu.o interrupts.o watchdog.o time.o cache.o \
-		pci-sh4.o pci-sh7780.o
+		pci-sh4.o pci-sh7751.o pci-sh7780.o
 
 all:	.depend $(START) $(LIB)
cpu/sh4/pci-sh7751.c new file +204 -0

204 lines not on this page · raw message

include/asm-sh/pci.h +3 -1
index 821961f..d53ded4 100644
@@ -29,7 +29,9 @@
 
 #include <pci.h>
 
-#if defined(CONFIG_CPU_SH7780)
+#if defined(CONFIG_CPU_SH7751)
+int pci_sh7751_init(struct pci_controller *hose);
+#elif defined(CONFIG_CPU_SH7780)
 int pci_sh7780_init(struct pci_controller *hose);
 #else
 #error "Not support PCI."
Signature · 1 line
1.5.4.3
#1 lore raw

PATCH 1/1 sh: Add support PCI host driver for SH7751/SH7751R

Quoted 13 lines · Nobuhiro Iwamatsu
Signed-off-by Nobuhiro Iwamatsu <[email protected]>
---
 cpu/sh4/Makefile     |    2 +-
 cpu/sh4/pci-sh7751.c |  204 ++++++++++++++++++++++++++++++++++++++++++++++++++
 include/asm-sh/pci.h |    4 +-
 3 files changed, 208 insertions(+), 2 deletions(-)
 create mode 100644 cpu/sh4/pci-sh7751.c
cpu/sh4/Makefile +0 -0
index 7a53cb6..6dc8a59 100644

cpu/sh4/Makefile LIB = $(obj)lib$(CPU).a · line 33

Quoted 5 lines
cpu/sh4/Makefile +1 -1
@@ -30,7 +30,7 @@ LIB	= $(obj)lib$(CPU).a
 
 START	= start.o
 OBJS	= cpu.o interrupts.o watchdog.o time.o cache.o \
-		pci-sh4.o pci-sh7780.o
+		pci-sh4.o pci-sh7751.o pci-sh7780.o

Could you split it to one line for one file

Quoted 27 lines
cpu/sh4/Makefile +0 -0
 all:	.depend $(START) $(LIB)
cpu/sh4/pci-sh7751.c new file +18 -0
new file mode 100644
index 0000000..86d64dd
@@ -0,0 +1,204 @@
+/*
+ * SH7751 PCI Controller (PCIC) for U-Boot.
+ * (C) Dustin McIntire (dustin at sensoria.com)
+ * (C) 2007,2008 Nobuhiro Iwamatsu <[email protected]>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *

cpu/sh4/pci-sh7751.c line 28

Quoted 10 lines
cpu/sh4/pci-sh7751.c new file +10 -0
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include <common.h>
+
+#if defined(CONFIG_PCI) && defined(CONFIG_SH4_PCI) \
+	&& defined(CONFIG_SH7751_PCI)

Could you move it to the Makefile

cpu/sh4/pci-sh7751.c line 32

Quoted 4 lines
cpu/sh4/pci-sh7751.c new file +4 -0
+
+#include <asm/processor.h>
+#include <asm/io.h>
+#include <pci.h>

I think it will be good to move the pci drivers to drivers/pci

Best Regards,
J.

author
#2 lore raw

PATCH 1/1 sh: Add support PCI host driver for SH7751/SH7751R

Hi ,

Thank you for your check.

Quoted 8 lines · On Wed, 12 Mar 2008 23:09:50 +0100 Jean-Christophe PLAGNIOL-VILLARD…

cpu/sh4/Makefile LIB = $(obj)lib$(CPU).a · line 33

Quoted 4 lines

START = start.o
OBJS = cpu.o interrupts.o watchdog.o time.o cache.o \

cpu/sh4/Makefile +1 -1
-		pci-sh4.o pci-sh7780.o
+		pci-sh4.o pci-sh7751.o pci-sh7780.o

Could you split it to one line for one file

cpu/sh4/pci-sh7751.c line 28

Quoted 2 lines
cpu/sh4/pci-sh7751.c new file +2 -0
+#if defined(CONFIG_PCI) && defined(CONFIG_SH4_PCI) \
+	&& defined(CONFIG_SH7751_PCI)

Could you move it to the Makefile

[snip]

Quoted 6 lines

cpu/sh4/pci-sh7751.c line 32

Quoted 4 lines
cpu/sh4/pci-sh7751.c new file +4 -0
+
+#include <asm/processor.h>
+#include <asm/io.h>
+#include <pci.h>

I think it will be good to move the pci drivers to drivers/pci

OK, I will fix this, send patch .

regards,
Nobuhiro

Signature · 3 lines
Nobuhiro Iwamatsu
        iwamatsu @ nigauri.org / superh.org / debian.or.jp
	GPG ID : 3170EBE9