Skip to contentSkip to conversation

x86_64: free_bootmem should take phy

PATCH In review Yinghai Lu 2 participants 3 messages Mar 13, 2008

Subsystems (2)
lore
Share & tools
lore

Yinghai Lu

author
#0 lore raw

PATCH 1/1 x86_64: free_bootmem should take phy

[PATCH] x86_64: free_bootmem should take phys

so use nodedata_phys directly.

arch/x86/mm/numa_64.c +1 -2
index 0c9b2bd..18267a0 100644
@@ -221,8 +221,7 @@ void __init setup_node_bootmem(int nodeid, unsigned long start,
 				 bootmap_pages<<PAGE_SHIFT, PAGE_SIZE);
 	if (bootmap == NULL)  {
 		if (nodedata_phys < start || nodedata_phys >= end)
-			free_bootmem((unsigned long)node_data[nodeid],
-				     pgdat_size);
+			free_bootmem(nodedata_phys, pgdat_size);
 		node_data[nodeid] = NULL;
 		return;
 	}
#1 lore raw
Quoted 12 lines · On Thu, 13 Mar 2008 12:13:23 -0700 "Yinghai Lu" <[email protected]> wrote:

[PATCH] x86_64: free_bootmem should take phys

so use nodedata_phys directly.

arch/x86/mm/numa_64.c +0 -0
index 0c9b2bd..18267a0 100644

arch/x86/mm/numa_64.c void __init setup_node_bootmem(int nodeid, unsigned long start, · line 227

Quoted 9 lines
arch/x86/mm/numa_64.c +1 -2
@@ -221,8 +221,7 @@ void __init setup_node_bootmem(int nodeid, unsigned long start,
 				 bootmap_pages<<PAGE_SHIFT, PAGE_SIZE);
 	if (bootmap == NULL)  {
 		if (nodedata_phys < start || nodedata_phys >= end)
-			free_bootmem((unsigned long)node_data[nodeid],
-				     pgdat_size);
+			free_bootmem(nodedata_phys, pgdat_size);
 		node_data[nodeid] = NULL;
 		return;
 	}

Can you please confirm that this change has no dependency upon your other recent changes?

Thanks.

author
#2 lore raw
Quoted 19 lines · Andrew Morton
Quoted 16 lines · On Thu, 13 Mar 2008 12:13:23 -0700 "Yinghai Lu" <[email protected]> wrote:

[PATCH] x86_64: free_bootmem should take phys

so use nodedata_phys directly.

arch/x86/mm/numa_64.c +0 -2
index 0c9b2bd..18267a0 100644
@@ -221,8 +221,7 @@ void __init setup_node_bootmem(int nodeid, unsigned long start,
                               bootmap_pages<<PAGE_SHIFT, PAGE_SIZE);
      if (bootmap == NULL)  {
              if (nodedata_phys < start || nodedata_phys >= end)
-                     free_bootmem((unsigned long)node_data[nodeid],
-                                  pgdat_size);
Quoted 8 lines

arch/x86/mm/numa_64.c void __init setup_node_bootmem(int nodeid, unsigned long start, · line 227

Quoted 5 lines
arch/x86/mm/numa_64.c +1 -0
+                     free_bootmem(nodedata_phys, pgdat_size);
              node_data[nodeid] = NULL;
              return;
      }

Can you please confirm that this change has no dependency upon your other recent changes?

it has not dependency upon to other recent changes.

YH