ibm_newemac: emac_tx_csum typo fix.patch
Subsystems (2)
PATCH 1/1 ibm_newemac: emac_tx_csum typo fix.patch
Move the "&& skb->ip_summed == CHECKSUM_PARTIAL" part out of emac_has_feature parameters.
Signed-off-by Valentine Barshak <[email protected]>
--- drivers/net/ibm_newemac/core.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/ibm_newemac/core.c +2 -2
@@ -1235,8 +1235,8 @@ static int emac_close(struct net_devicestatic inline u16 emac_tx_csum (struct emac_instance *dev,struct sk_buff *skb) { -if (emac_has_feature (dev,EMAC_FTR_HAS_TAH && - skb->ip_summed ==CHECKSUM_PARTIAL )) { +if (emac_has_feature (dev,EMAC_FTR_HAS_TAH ) && + (skb->ip_summed ==CHECKSUM_PARTIAL )) { ++dev->stats.tx_packets_csum;return EMAC_TX_CTRL_TAH_CSUM ; }
Quoted 4 lines · Valentine Barshak
Move the "&&
skb->ip_summed==CHECKSUM_PARTIAL" part out ofemac_has_featureparameters.Signed-off-by Valentine Barshak <[email protected]>
Acked-by Stefan Roese <[email protected]>
I think this is 2.6.25 material. I just stumbled over this problem too while enabling TAH on 440GX and 460EX/GT.
Thanks.
Best regards,
Stefan