Skip to contentSkip to conversation

bridge: use time_before() in br_fdb_cleanup()

PATCH Applied Stephen Hemminger 2 participants 2 messages Mar 19, 2008 – Mar 20, 2008

Subsystems (3)
Networking Network drivers Ethernet bridge
lore
Share & tools
lore

Stephen Hemminger

author
#0 lore raw

PATCH 1/1 bridge: use time_before() in br_fdb_cleanup()

In br_fdb_cleanup() next_timer and this_timer are in jiffies, so they should be compared using the time_after() macro.

Signed-off-by Fabio Checconi <[email protected]>
Signed-off-by Stephen Hemminger <[email protected]>
---
 net/bridge/br_fdb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
net/bridge/br_fdb.c +1 -1
index bc40377..9326c37 100644
@@ -136,7 +136,7 @@ void br_fdb_cleanup(unsigned long _data)
 			this_timer = f->ageing_timer + delay;
 			if (time_before_eq(this_timer, jiffies))
 				fdb_delete(f);
-			else if (this_timer < next_timer)
+			else if (time_before(this_timer, next_timer))
 				next_timer = this_timer;
 		}
 	}
Signature · 1 line
1.5.4.3