Skip to contentSkip to conversation

ColdFire: Fix FEC transmit issue for MCF5275

PATCH New Tsi-Chung Liew 3 participants 3 messages Mar 17, 2008 – Mar 30, 2008 Network drivers

lore
Share & tools
lore

Tsi-Chung Liew

author
#0 lore raw

PATCH 1/1 ColdFire: Fix FEC transmit issue for MCF5275

Signed-off-by TsiChung Liew <[email protected]>
---
 drivers/net/mcffec.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
drivers/net/mcffec.c +7 -0
index 3b81258..71d1960 100644
@@ -166,6 +166,13 @@ int fec_send(struct eth_device *dev, volatile void *packet, int length)
 	/* Activate transmit Buffer Descriptor polling */
 	fecp->tdar = 0x01000000;	/* Descriptor polling active    */
 
+	/* FEC fix for MCF5275, FEC unable to initial transmit data packet.
+	 * A nop will ensure the descriptor polling active completed.
+	 */
+#ifdef CONFIG_M5275
+	__asm__ ("nop");
+#endif
+
 #ifdef CFG_UNIFY_CACHE
 	icache_invalid();
 #endif
Signature · 1 line
1.5.4.1
#1 lore raw

PATCH 1/1 ColdFire: Fix FEC transmit issue for MCF5275

Quoted 10 lines · In message <[email protected]>…
Signed-off-by TsiChung Liew <[email protected]>
---
 drivers/net/mcffec.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
drivers/net/mcffec.c +0 -0
index 3b81258..71d1960 100644

drivers/net/mcffec.c int fec_send(struct eth_device *dev, volatile void *packet, int length) · line 171

Quoted 6 lines
drivers/net/mcffec.c +3 -0
@@ -166,6 +166,13 @@ int fec_send(struct eth_device *dev, volatile void *packet, int length)
 	/* Activate transmit Buffer Descriptor polling */
 	fecp->tdar = 0x01000000;	/* Descriptor polling active    */
 
+	/* FEC fix for MCF5275, FEC unable to initial transmit data packet.
+	 * A nop will ensure the descriptor polling active completed.
+	 */

Please note:

The preferred style for long (multi-line) comments is:

/*
* This is the preferred style for multi-line
* comments in the Linux kernel source code.
* Please use it consistently.
*
* Description: A column of asterisks on the left side,
* with beginning and ending almost-blank lines. */

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A meeting is an event at which the minutes are kept and the hours are
lost.
Applied
#2 lore raw

PATCH 1/1 ColdFire: Fix FEC transmit issue for MCF5275

In reply to Tsi-Chung Liew
Quoted 14 lines · Tsi-Chung Liew
Signed-off-by TsiChung Liew <[email protected]>
---
 drivers/net/mcffec.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
drivers/net/mcffec.c +0 -0
index 3b81258..71d1960 100644
@@ -166,6 +166,13 @@ int fec_send(struct eth_device *dev, volatile void *packet, int length)
 	/* Activate transmit Buffer Descriptor polling */
 	fecp->tdar = 0x01000000;	/* Descriptor polling active    */

drivers/net/mcffec.c int fec_send(struct eth_device *dev, volatile void *packet, int length) · line 178

Quoted 10 lines
drivers/net/mcffec.c +7 -0
+	/* FEC fix for MCF5275, FEC unable to initial transmit data packet.
+	 * A nop will ensure the descriptor polling active completed.
+	 */
+#ifdef CONFIG_M5275
+	__asm__ ("nop");
+#endif
+
 #ifdef CFG_UNIFY_CACHE
 	icache_invalid();
 #endif

Applied to net tree. As others have noted, adding a NOP here seems like a band-aid, but I can't really dispute it.

thanks,
Ben