iscsi_ibft build error
mmotm-2008-0318-1720/drivers/firmware/iscsi_ibft.c: In function 'ibft_show_attribute':mmotm-2008-0318-1720/drivers/firmware/iscsi_ibft.c:521: error: implicit declaration of function 'capable' mmotm-2008-0318-1720/drivers/firmware/iscsi_ibft.c:521: error: 'CAP_SYS_ADMIN' undeclared (first use in this function) mmotm-2008-0318-1720/drivers/firmware/iscsi_ibft.c:521: error: (Each undeclared identifier is reported only once mmotm-2008-0318-1720/drivers/firmware/iscsi_ibft.c:521: error: for each function it appears in.) make[3]: *** [drivers/firmware/iscsi_ibft.o] Error 1
---
~Randy
Quoted 7 lines · On Wed, 19 Mar 2008 11:56:55 -0700 Randy Dunlap <[email protected]> wrote:
mmotm-2008-0318-1720/drivers/firmware/iscsi_ibft.c: In function 'ibft_show_attribute':mmotm-2008-0318-1720/drivers/firmware/iscsi_ibft.c:521: error: implicit declaration of function 'capable'mmotm-2008-0318-1720/drivers/firmware/iscsi_ibft.c:521: error: 'CAP_SYS_ADMIN' undeclared (first use in this function)mmotm-2008-0318-1720/drivers/firmware/iscsi_ibft.c:521: error: (Each undeclared identifier is reported only oncemmotm-2008-0318-1720/drivers/firmware/iscsi_ibft.c:521: error: for each function it appears in.) make[3]: *** [drivers/firmware/iscsi_ibft.o] Error 1
drivers/firmware/iscsi_ibft.c renamed from drivers/firmware/iscsi_ibft.c~scsi-add-iscsi-ibft-support-fix +1 -0
@@ -65,6 +65,7 @@#include <linux/blkdev.h> +#include <linux/capability.h> #include <linux/ctype.h> #include <linux/device.h> #include <linux/err.h>
should do the trick.
Does this driver actually need to run capable(CAP_SYS_ADMIN)? Can we not rely upon permissions of the reelvant sysfs file?
Quoted 22 lines · Andrew Morton
Quoted 7 lines · On Wed, 19 Mar 2008 11:56:55 -0700 Randy Dunlap <[email protected]> wrote:
mmotm-2008-0318-1720/drivers/firmware/iscsi_ibft.c: In function 'ibft_show_attribute':mmotm-2008-0318-1720/drivers/firmware/iscsi_ibft.c:521: error: implicit declaration of function 'capable'mmotm-2008-0318-1720/drivers/firmware/iscsi_ibft.c:521: error: 'CAP_SYS_ADMIN' undeclared (first use in this function)mmotm-2008-0318-1720/drivers/firmware/iscsi_ibft.c:521: error: (Each undeclared identifier is reported only oncemmotm-2008-0318-1720/drivers/firmware/iscsi_ibft.c:521: error: for each function it appears in.) make[3]: *** [drivers/firmware/iscsi_ibft.o] Error 1drivers/firmware/iscsi_ibft.c renamed from drivers/firmware/iscsi_ibft.c~scsi-add-iscsi-ibft-support-fix +1
-0@@ -65,6 +65,7 @@#include <linux/blkdev.h> +#include <linux/capability.h> #include <linux/ctype.h> #include <linux/device.h> #include <linux/err.h>
Quoted 4 lines
should do the trick.
Does this driver actually need to run
capable(CAP_SYS_ADMIN)? Can we not rely upon permissions of the reelvant sysfs file?
I followed what the efivars driver does. The permissions of the files are secure (as they are in the efivars), so one layer of protection could be suffice?