Skip to contentSkip to conversation

New: executables with read bit 'off' cannot open /dev/stdin

Bugme-new Andrew Morton 3 participants 4 messages Mar 19, 2008 – Mar 20, 2008 1 message not in the archive VFS

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]/

#1 lore raw

(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface).

Quoted 17 lines · On Wed, 19 Mar 2008 13:15:36 -0700 (PDT) [email protected] wrote:

http://bugzilla.kernel.org/show_bug.cgi?id=10284

Summary: executables with read bit 'off' cannot open /dev/stdin
Product: File System
Version: 2.5
KernelVersion: 2.6.16.27-0.9-smp
Platform: All
OS/Version: Linux
Tree: Mainline
Status: NEW
Severity: normal
Priority: P1
Component: devfs
AssignedTo: [email protected]
ReportedBy: [email protected]

Quoted 7 lines

Latest working kernel version: 2.6.16.27
Earliest failing kernel version: 2.4.21
Distribution: suse
Hardware Environment: x86_64
Software Environment:
Problem Description: if the read bit of a binary executable is off, then open() on /dev/stdin fails with a EACCES error.

This is, umm, unexpected?

Quoted 61 lines

Steps to reproduce:
A short program that calls open on /dev/stdin:

cat open_stdin.c
#include <stdio.h>
#include <stdlib.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>

int main(int argc, char **argv) {
open("/dev/stdin",O_RDONLY);
return 0;
}

tracing system calls with normal operation shows that this completes successfully. But:

chmod -r open_stdin
strace ./open_stdin
execve("./open_stdin", ["./open_stdin"], [/* 96 vars */]) = 0
brk(0) = 0x501000
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x2b25d01b6000
uname({sys="Linux", node="lush", ...}) = 0
access("/etc/ld.so.preload", R_OK) = -1 ENOENT (No such file or directory)
... (open's on .so's deleted) ...
open("/etc/ld.so.cache", O_RDONLY) = 3
fstat(3, {st_mode=S_IFREG|0644, st_size=158841, ...}) = 0 mmap(NULL, 158841, PROT_READ, MAP_PRIVATE, 3, 0) = 0x2b25d01b7000
close(3) = 0
open("/lib64/libc.so.6", O_RDONLY) = 3
read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0P\322\1\0"..., 832) = 832
fstat(3, {st_mode=S_IFREG|0755, st_size=1475924, ...}) = 0 mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x2b25d01de000
mmap(NULL, 2289896, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x2b25d02b8000
madvise(0x2b25d02b8000, 2289896, MADV_SEQUENTIAL|0x1) = 0 mprotect(0x2b25d03df000, 1044480, PROT_NONE) = 0 mmap(0x2b25d04de000, 20480, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x126000) = 0x2b25d04de000 mmap(0x2b25d04e3000, 16616, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x2b25d04e3000close(3)

                    = 0

mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x2b25d04e8000
arch_prctl(ARCH_SET_FS, 0x2b25d04e86d0) = 0 mprotect(0x2b25d04de000, 12288, PROT_READ) = 0
munmap(0x2b25d01b7000, 158841) = 0
open("/dev/stdin", O_RDONLY) = -1 EACCES (Permission denied)

The last line shows a Permission denied error on opening /dev/stdin. If a normal filesystem (i.e. not-/dev/) filename is used, the open works normally.

I have reproduced this on 2.4 and 2.6 kernels
Just a guess here: is an error flag from attempting to read the binary not getting cleared and is being reported when trying to open stdin?

#2 lore raw
Quoted 4 lines · Andrew Morton
Quoted 2 lines

Problem Description: if the read bit of a binary executable is off, then open() on /dev/stdin fails with a EACCES error.

This is, umm, unexpected?

I'm not sure it's unexpected. It's undesirable, certainly.

Quoted 8 lines
Quoted 8 lines

open("/dev/stdin", O_RDONLY) = -1 EACCES (Permission denied)

The last line shows a Permission denied error on opening /dev/stdin. If a normal filesystem (i.e. not-/dev/) filename is used, the open works normally.

I have reproduced this on 2.4 and 2.6 kernels
Just a guess here: is an error flag from attempting to read the binary not getting cleared and is being reported when trying to open stdin?

I think the guess is faulty. Could you show ls -l /dev/stdin ? On my system, it reports:

lrwxrwxrwx 1 root root 15 2008-03-10 11:03 /dev/stdin -> /proc/self/fd/0

Wild guess: Users can't access /proc/ directories of executables with the read-bit clear in order to prevent users from reading the state anyway.

I wonder how effective clearing the read-bit is these days. Don't we all have source to all the applications anyway? ;-)

Signature · 4 lines
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
#3 lore raw
In reply to Andrew Morton
Quoted 2 lines · Andrew Morton

(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface).

Unfortunately, Joe seems not to be able to follow that instruction. He's left two comments in bugzilla which are not reflected in this email thread.

Quoted 10 lines
Quoted 10 lines
     KernelVersion: 2.6.16.27-0.9-smp

A short program that calls open on /dev/stdin:

cat open_stdin.c
#include <stdio.h>
#include <stdlib.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>

Quoted 4 lines
Quoted 4 lines

int main(int argc, char **argv) {
open("/dev/stdin",O_RDONLY);
return 0;
}

I've tried this program on 2.6.25-rc3-00093-g59e1338-dirty and it does not fail.

Quoted 1 line
Quoted 1 line

open("/dev/stdin", O_RDONLY) = -1 EACCES (Permission denied)

Specifically, my tests show:

open-stdin-readable:open("/dev/stdin", O_RDONLY) = 3
open-stdin-unreadable:open("/dev/stdin", O_RDONLY) = 3

Joe, can you try a more recent kernel?

Another thing to try would be opening /proc/self/fd/0 or /dev/pts/0 in your program and seeing whether those fail.

Signature · 4 lines
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
#4 lore raw
Quoted 6 lines · On Wed, 19 Mar 2008 19:56:50 -0600 Matthew Wilcox <[email protected]> wrote:

I've tried this program on 2.6.25-rc3-00093-g59e1338-dirty and it does not fail.

Quoted 2 lines
Quoted 2 lines

open("/dev/stdin", O_RDONLY) = -1 EACCES (Permission
denied)

Quoted 6 lines

Specifically, my tests show:

open-stdin-readable:open("/dev/stdin", O_RDONLY) = 3
open-stdin-unreadable:open("/dev/stdin", O_RDONLY) = 3

Joe, can you try a more recent kernel?

another interesting question is if you're using some special LSM/security stuff..

Signature · 3 lines
If you want to reach me at my work email, use [email protected]
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org