Skip to contentSkip to conversation

pids: __set_special_pids: use change_pid() helper

PATCH New Oleg Nesterov 1 participant 1 message Mar 20, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 3/4 pids: __set_special_pids: use change_pid() helper

Use change_pid() instead of detach_pid() + attach_pid() in __set_special_pids()

This way task_session() is not NULL in between.

kernel/exit.c renamed from kernel/exit.c~4_SETSID +2 -4
@@ -334,13 +334,11 @@ void __set_special_pids(struct pid *pid)
 	pid_t nr = pid_nr(pid);
 
 	if (task_session(curr) != pid) {
-		detach_pid(curr, PIDTYPE_SID);
-		attach_pid(curr, PIDTYPE_SID, pid);
+		change_pid(curr, PIDTYPE_SID, pid);
 		set_task_session(curr, nr);
 	}
 	if (task_pgrp(curr) != pid) {
-		detach_pid(curr, PIDTYPE_PGID);
-		attach_pid(curr, PIDTYPE_PGID, pid);
+		change_pid(curr, PIDTYPE_PGID, pid);
 		set_task_pgrp(curr, nr);
 	}
 }