Skip to contentSkip to conversation

Fix sh_keysc double free

PATCH Applied Magnus Damm 2 participants 2 messages Mar 21, 2008 – Mar 24, 2008

Subsystems (3)
HID SuperH Input drivers
lore
Share & tools
lore

Magnus Damm

author
#0 lore raw

PATCH 1/1 Fix sh_keysc double free

Avoid double free situation from happening by removing input_free_device() after input_unregister_device(). Suggested by Dmitry Torokhov.

Signed-off-by Magnus Damm <[email protected]>

---

 drivers/input/keyboard/sh_keysc.c |    1 -
 1 file changed, 1 deletion(-)
drivers/input/keyboard/sh_keysc.c +0 -1
@@ -238,7 +238,6 @@ static int __devexit sh_keysc_remove(str
 
 	input_unregister_device(priv->input);
 	free_irq(platform_get_irq(pdev, 0), pdev);
-	input_free_device(priv->input);
 	iounmap(priv->iomem_base);
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
Applied
#1 lore raw
Quoted 4 lines · Magnus Damm

Avoid double free situation from happening by removing input_free_device() after input_unregister_device(). Suggested by Dmitry Torokhov.

Signed-off-by Magnus Damm <[email protected]>

Applied, thanks.