Skip to contentSkip to conversation

x86_64: allcate e820 resource struct all together

PATCH In review Yinghai Lu 2 participants 2 messages Mar 21, 2008 x86

lore
Share & tools
lore

Yinghai Lu

author
#0 lore raw

PATCH 1/1 x86_64: allcate e820 resource struct all together

don't need to allocate that one by one

Signed-off-by Yinghai Lu <[email protected]>
arch/x86/kernel/e820_64.c +3 -2
Index: linux-2.6/arch/x86/kernel/e820_64.c
===================================================================
@@ -237,9 +237,9 @@ unsigned long __init e820_end_of_ram(voi
 void __init e820_reserve_resources(void)
 {
 	int i;
+	struct resource *res;
+	res = alloc_bootmem_low(sizeof(struct resource) * e820.nr_map);
 	for (i = 0; i < e820.nr_map; i++) {
-		struct resource *res;
-		res = alloc_bootmem_low(sizeof(struct resource));
 		switch (e820.map[i].type) {
 		case E820_RAM:	res->name = "System RAM"; break;
 		case E820_ACPI:	res->name = "ACPI Tables"; break;

@@ -250,6 +250,7 @@ void __init e820_reserve_resources(void)
 		res->end = res->start + e820.map[i].size - 1;
 		res->flags = IORESOURCE_MEM | IORESOURCE_BUSY;
 		insert_resource(&iomem_resource, res);
+		res++;
 	}
 }
#1 lore raw

arch/x86/kernel/e820_64.c unsigned long __init e820_end_of_ram(voi · line 241

Quoted 4 lines · Yinghai Lu

don't need to allocate that one by one

arch/x86/kernel/e820_64.c +2 -0
+	struct resource *res;
+	res = alloc_bootmem_low(sizeof(struct resource) * e820.nr_map);

nice one - applied.

(minor style nit: please keep a newline between variable definitions and the first line of code, to make it a bit more readable.)

Ingo